Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup-open-p4studio.bash Configuration for install.sh Users #43

Closed

Conversation

OrangeTaoer
Copy link

This PR introduces the creation of a setup-open-p4studio.bash script specifically for users who utilize the install.sh script. The purpose of this script is to set up the necessary environment variables to ensure seamless operation of Open P4 Studio.

@jafingerhut
Copy link
Contributor

I am hoping that PR #38 will be approved and merged relatively soon.

If so, I would recommend that this PR change most of your new code to a line like this, to reuse existing code, and enable there to be one place rather than two that create this setup file:

./create-setup-script.sh > ~/setup-open-p4studio.bash

https://github.com/p4lang/open-p4studio/pull/38/files#diff-4eb3cdfae4cd6d0410dc2b8fe3e317e740126a0c25d4120bfec9ce80fba91a68

@jafingerhut
Copy link
Contributor

Also for future reference, this PR is failing the DCO check. Look on the Github page for this PR at #43 and find the section near the bottom with "Some checks were not successful", and click on the "Details" link to the right of "DCO". There you should be able to find detailed instructions on changing a PR so that it passes the check.

When creating a new PR for this or any other repository in https://github.com/p4lang, you should always use the -s option on git commit commands, which will include a line "Signed off by" with your name and email address in the commit, enabling the PR to pass the DCO checks.

@OrangeTaoer
Copy link
Author

@jafingerhut Thanks. And I change one account to submit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants