Add the Tofino model source code as a package in the open P4Studio #65
Conversation
fruffy
commented
Feb 3, 2025
•
fruffy
commented
- Compile on Ubuntu 20.04 and 22.04.
- Use the generated binary instead of the available binary.
- Add an option to disable model building and just use the latest binary.
- Polish (Remove unnecessary code)
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
|
"Files changed 5000+" Now there is a thing you don't see in a Github PR every day :-) |
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
| // __LINE__, | ||
| // port_handle, | ||
| // port_lane_list, | ||
| // status); |
There was a problem hiding this comment.
Do you want to merge this PR with this code commented out? Or perhaps wrap them all in an #ifdef SOME_NEW_SYMBOL_NAME with the same symbol name as each other, to make them easier to grep and find later when someone wants to update all of these calls? I guess marking them all with an identical unique string in a comment works for that, too.
There was a problem hiding this comment.
I will remove these changes later. But I need them to build on Ubuntu 24.04, which is the distribution I am currently using.
The problem is that this code doesn't compile with newer version of GCC/CLang, which enforce the C++ standard correctly.
