Merge pull request #4 from open-source-contributions/improve_array_rand

Using the random_int to improve array_rand
pH-7 · Nov 30, 2022 · 5106fe4 · 5106fe4
2 parents 091a3b9 + 2749589
commit 5106fe4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Generator/Password.php b/src/Generator/Password.php
@@ -23,9 +23,10 @@ public static function generate(int $length = self::DEFAULT_LENGTH, bool $specia
             range('Z', 'Z'),
             $specialCharacters ? self::SPECIAL_CHARACTERS : []
         );
+        $endKeysIndex = count($keys) - 1;
 
         for ($amount = 0; $amount < $length; $amount++) {
-            $password .= $keys[array_rand($keys)];
+            $password .= $keys[random_int(0, $endKeysIndex)];
         }
 
         return $password;