BUGFIX: make setState handling more robust in ImageEditor to prevent …

…warning if unmounted (needed to have the tests run through)
pKallert · Sep 13, 2024 · 28bf36c · 28bf36c
1 parent 38bd6a1
commit 28bf36c
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/packages/neos-ui-editors/src/Editors/Image/index.js b/packages/neos-ui-editors/src/Editors/Image/index.js
@@ -72,7 +72,9 @@ export default class ImageEditor extends Component {
                 isAssetLoading: true
             }, () => {
                 this.loadImage = loadImageMetadata(this.props.value.__identity).then(image => {
-                    this.setState({image, isAssetLoading: false});
+                    if (this._isMounted) {
+                        this.setState({image, isAssetLoading: false});
+                    }
                 });
             });
         }
@@ -88,7 +90,9 @@ export default class ImageEditor extends Component {
         const {loadImageMetadata} = backend.get().endpoints;
 
         if (!nextProps.value || !nextProps.value.__identity) {
-            this.setState({image: null});
+            if (this._isMounted) {
+                this.setState({image: null});
+            }
         }
 
         //
@@ -101,14 +105,16 @@ export default class ImageEditor extends Component {
                         image,
                         isAssetLoading: false
                     }, () => {
-                        // When forceCrop option is enabled and we were requested to do the force cropping...
-                        if (this.state.requestOpenImageCropper && $get('crop.aspectRatio.forceCrop', this.props.options)) {
-                            this.handleCloseSecondaryScreen();
-                            this.handleOpenImageCropper();
-                            this.setState({requestOpenImageCropper: false});
-                        } else if (this.state.isImageCropperOpen) {
-                            this.handleCloseSecondaryScreen();
-                            this.handleOpenImageCropper();
+                        if (this._isMounted) {
+                            // When forceCrop option is enabled and we were requested to do the force cropping...
+                            if (this.state.requestOpenImageCropper && $get('crop.aspectRatio.forceCrop', this.props.options)) {
+                                this.handleCloseSecondaryScreen();
+                                this.handleOpenImageCropper();
+                                this.setState({requestOpenImageCropper: false});
+                            } else if (this.state.isImageCropperOpen) {
+                                this.handleCloseSecondaryScreen();
+                                this.handleOpenImageCropper();
+                            }
                         }
                     });
                 }