Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ESLint Shareable Config, eslint-config-pa11y #11

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

danyalaytekin
Copy link
Member

This PR updates the project to become an ESLint Shareable Config and adds a test in CI to verify that it can be installed and used. These insist on the prefix eslint.

Changes

  • Rename package.name to eslint-config-pa11y from pa11y-lint-config
  • Test installation and usage of the config into a temporary project in GitHub Actions, referencing it by the name pa11y
    • this can be parameterised in future to cover specific versions of ESLint

@danyalaytekin danyalaytekin added this to the 4.0.0 milestone Mar 23, 2024
@danyalaytekin danyalaytekin self-assigned this Mar 23, 2024
@danyalaytekin danyalaytekin changed the title [WIP, draft] Convert to ESLint Shareable Config, eslint-config-pa11y Convert to ESLint Shareable Config, eslint-config-pa11y Mar 26, 2024
@danyalaytekin danyalaytekin marked this pull request as ready for review March 26, 2024 07:25
Copy link
Member

@hollsk hollsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@danyalaytekin danyalaytekin merged commit 46528ae into main Apr 10, 2024
6 checks passed
@danyalaytekin danyalaytekin deleted the convert-to-eslint-shareable-config branch April 10, 2024 10:30
@danyalaytekin
Copy link
Member Author

danyalaytekin commented Apr 10, 2024

Thanks for the review @hollsk. I'll fix the issue that has arisen in main. I think it's because ESLint released version 9 since the tests ran previously, and the new test script introduced here just installs the latest version of ESLint. I suppose in a way it's good that it caught this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants