Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INF-1645] Switch to github.com/go-jose/go-jose/v4 #136

Merged
merged 11 commits into from
Jan 3, 2025
Merged

[INF-1645] Switch to github.com/go-jose/go-jose/v4 #136

merged 11 commits into from
Jan 3, 2025

Conversation

robert-uhl
Copy link

@robert-uhl robert-uhl commented Dec 23, 2024 •
edited
Loading

Overview

And regenerate generated files.

  • Switch from gopkg.in/square/go-jose.v2 to github.com/go-jose/go-jose/v4 (and make a small change to satisfy the new jose.ParseSigned signature — commit 7add84c fixes a bug in that change).
  • Update the Alpine Go version to handle that.
  • Updated go-sqlite3 to address a compilation failure.
  • Update the CI Go version.
  • Update to the current Docker Compose syntax.
  • Allow RSA for testing against MySQL with current Go.
  • Use a recent golangci-lint and delint.

What this PR does / why we need it

Updates a deprecated dependency.

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

@robert-uhl robert-uhl added the enhancement New feature or request label Dec 23, 2024
@robert-uhl robert-uhl marked this pull request as ready for review January 2, 2025 21:12
@robert-uhl robert-uhl changed the title Switch to github.com/go-jose/go-jose/v4 [INF-1645] Switch to github.com/go-jose/go-jose/v4 Jan 3, 2025
acohen4
acohen4 approved these changes Jan 3, 2025
View reviewed changes
Copy link

@acohen4 acohen4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-uhl robert-uhl merged commit 292f1ae into master Jan 3, 2025
5 checks passed
@robert-uhl robert-uhl deleted the rau/update-go-jose branch January 3, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acohen4 acohen4 acohen4 approved these changes

Assignees

@acohen4 acohen4

Labels
enhancement New feature or request kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert-uhl @acohen4