Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present precip and snowfall in cumulative units #191

Merged
merged 23 commits into from
Jul 2, 2020

Conversation

rod-glover
Copy link
Contributor

@rod-glover rod-glover commented Jun 30, 2020

This PR resolves #173 by doing the following things:

  • Revise the units configuration objects (units specs) to include labels (different than their identifiers) so distinct units specs (with distinct conversions) can present the same label. In particular, this is used for the cumulative precipitation units mm/year (cum), mm/season (cum), etc., which are all labelled mm but which are each scaled differently from the base units of kg m-2 d-1.
  • Introduces and uses conversions from units spec shorthands to canonical units specs. All configuration objects now are (or should be) converted to canonical units specs.
  • Merge the generic variables configuration item with display-specific variable configurations that depend on tab, season (annual, winter, ...), etc., and which include
    • display (absolute or relative anomaly values)
    • displayUnits (so that annual and winter precip values can be displayed with different cumulative units)
    • range, ticks (for maps and map colour bar)
  • Raise up configuration in the maps component tree.
  • Use more consistent naming for various objects.

This also goes partway to addressing #175 .

TODO:

  • Restore low baseline messages (config processing issue).
  • Add per-season configurations for other (non-precip) variables.
  • Remove absolute precip from Summary.
  • Set selector defaults back to normal.

@rod-glover rod-glover force-pushed the i173-precip-cumulative branch from c1b210b to 31f792a Compare June 30, 2020 23:57
@rod-glover rod-glover added this to the 1.2.0 milestone Jul 1, 2020
@rod-glover
Copy link
Contributor Author

Demo

@rod-glover rod-glover merged commit c90f7cf into master Jul 2, 2020
@rod-glover rod-glover deleted the i173-precip-cumulative branch July 2, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Present precip and snowfall in cumulative units
1 participant