Merge pull request #13 from jeremylong/resolveIssuesWithoutTestSuite

Updated Resolution for Issues #9 and #10
package-url · Jan 27, 2019 · f8db498 · f8db498
2 parents 54d90e4 + 1b92c42
commit f8db498
Show file tree

Hide file tree

Showing 8 changed files with 509 additions and 181 deletions.
diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.github.package-url</groupId>
     <artifactId>packageurl-java</artifactId>
-    <version>1.0.1-SNAPSHOT</version>
+    <version>1.1.0-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>Package URL</name>
@@ -51,6 +51,8 @@
         <plexus.compiler.javac.errorprone.version>2.8.5</plexus.compiler.javac.errorprone.version>
         <error.prone.core.version>2.3.2</error.prone.core.version>
         <jacoco.maven.plugin.version>0.8.2</jacoco.maven.plugin.version>
+        <spotbugs.maven.plugin.version>3.1.9</spotbugs.maven.plugin.version>
+        <com.github.spotbugs.version>3.1.10</com.github.spotbugs.version>
     </properties>
 
     <scm>
@@ -130,6 +132,27 @@
                     </dependency>
                 </dependencies>
             </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <version>${spotbugs.maven.plugin.version}</version>
+                <executions>
+                    <execution>
+                        <phase>package</phase>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+                <dependencies>
+                    <!-- overwrite dependency on spotbugs if you want to specify the version of spotbugs -->
+                    <dependency>
+                        <groupId>com.github.spotbugs</groupId>
+                        <artifactId>spotbugs</artifactId>
+                        <version>${com.github.spotbugs.version}</version>
+                    </dependency>
+                </dependencies>
+            </plugin>
             <plugin>
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>

diff --git a/src/main/java/com/github/packageurl/MalformedPackageURLException.java b/src/main/java/com/github/packageurl/MalformedPackageURLException.java
@@ -47,4 +47,4 @@ public MalformedPackageURLException(String msg) {
         super(msg);
     }
 
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,4 +47,4 @@ public MalformedPackageURLException(String msg) { @@
             super(msg);
         }
-    }
+    }