Resolve issues #9 and #10 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,7 +85,7 @@ | |||
| }, | |||
| { | |||
| "description": "docker uses qualifiers and hash image id as versions", | |||
| "purl": "pkg:docker/customer/dockerimage@sha256:244fd47e07d1004f0aed9c?repository_url=gcr.io", | |||
| "purl": "pkg:docker/customer/dockerimage@sha256%3A244fd47e07d1004f0aed9c?repository_url=gcr.io", | |||
There was a problem hiding this comment.
Blocked by: package-url/purl-spec#39
| @@ -109,7 +109,7 @@ | |||
| }, | |||
| { | |||
| "description": "maven often uses qualifiers", | |||
| "purl": "pkg:Maven/org.apache.xmlgraphics/[email protected]?repositorY_url=repo.spring.io/release&classifier=sources", | |||
| "purl": "pkg:Maven/org.apache.xmlgraphics/[email protected]?repositorY_url=repo.spring.io%2Frelease&classifier=sources", | |||
There was a problem hiding this comment.
Blocked by: package-url/purl-spec#39
| @@ -121,7 +121,7 @@ | |||
| }, | |||
| { | |||
| "description": "maven pom reference", | |||
| "purl": "pkg:Maven/org.apache.xmlgraphics/[email protected]?repositorY_url=repo.spring.io/release&extension=pom", | |||
| "purl": "pkg:Maven/org.apache.xmlgraphics/[email protected]?repositorY_url=repo.spring.io%2Frelease&extension=pom", | |||
There was a problem hiding this comment.
Blocked by: package-url/purl-spec#39
| @@ -264,7 +264,31 @@ | |||
| "is_invalid": false | |||
| }, | |||
| { | |||
| "description": "valid maven purl", | |||
| "description": "slash / between version and qualifiers separator is not significant", | |||
| "purl": "pkg:maven/org.apache.commons/[email protected]/?scope=test", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toString()as an alias for canonicalize.Note, this is using a modified
test-suite-data.jsonwhich has not yet been merged into the spec test suite (see package-url/purl-spec#52).