Introduce ecosystem-independent all and none schemes #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immqu
changed the title
tschmidtb51
suggested changes
Nov 13, 2024
tschmidtb51
reviewed
Nov 13, 2024
Comment on lines
+245
to
+246
| - ``vers:all/*`` | ||
| - ``vers:none/*`` |
There was a problem hiding this comment.
Also, we need to state somewhere that * is the only valid version constraint these versioning schemes can have and that no other construct is valid (even not a space in between).
There was a problem hiding this comment.
Currently, the document says A separate document will provide details for each versioning scheme. Is someone already taking care of this separate document?
There was a problem hiding this comment.
I'm not aware of that effort.
@pombredanne Any insights in this?
Signed-off-by: Kunz, Immanuel <[email protected]>
tschmidtb51
reviewed
Nov 14, 2024
Signed-off-by: Kunz, Immanuel <[email protected]>
Signed-off-by: Kunz, Immanuel <[email protected]>
Signed-off-by: Kunz, Immanuel <[email protected]>
Signed-off-by: Kunz, Immanuel <[email protected]>
|
@pombredanne can this PR be merged or are there any open points to discuss? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the possibility to specify all versions, or none, as suggested in #267 and implemented in aboutcode-org/univers#146