Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to mask log data #112

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add the ability to mask log data #112

merged 1 commit into from
Nov 27, 2023

Conversation

dbhynds
Copy link
Member

@dbhynds dbhynds commented Nov 20, 2023

Summary of Changes

Mask auth data in requests

Testing

  • I have added automated tests for my changes
  • I ran composer test before opening this PR
  • I ran composer lint-fix before opening this PR

Copy link

@lin-brian-l lin-brian-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbhynds great work! I manually verified that after copy+pasting your code into my local platform, logs for authentication were masked as expected while other logs weren't 💯.

@dbhynds dbhynds merged commit 8ca7783 into master Nov 27, 2023
3 checks passed
@dbhynds dbhynds deleted the logging branch November 27, 2023 15:49
dbhynds added a commit that referenced this pull request Nov 28, 2023
This reverts commit 8ca7783, reversing
changes made to 3ddfb3e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants