Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial changes for v6 #117

Closed
wants to merge 23 commits into from
Closed

Initial changes for v6 #117

wants to merge 23 commits into from

Conversation

dbhynds
Copy link
Member

@dbhynds dbhynds commented Dec 14, 2023

Summary of Changes

  • Removes everything marked deprecated.
  • Fixes everything marked to-do.
  • Adds initial upgrade documentation.
  • Types almost everything.
  • Implements constructor property promotion

Testing

Here's a pipeline with the latest changes: https://gitlab.com/packback/questions/-/pipelines/1107601809

  • I have added automated tests for my changes
  • I ran composer test before opening this PR
  • I ran composer lint-fix before opening this PR

@dbhynds dbhynds changed the base branch from v6.0-beta to fix-todos December 15, 2023 19:16
@dbhynds dbhynds changed the base branch from fix-todos to v6-phpstan December 15, 2023 19:52
Base automatically changed from v6-phpstan to v6.0-beta December 19, 2023 19:48
@dbhynds dbhynds changed the base branch from v6.0-beta to final-changes December 19, 2023 20:47
Base automatically changed from final-changes to v6.0-beta December 21, 2023 19:22
@dbhynds dbhynds closed this Dec 21, 2023
@dbhynds dbhynds deleted the lti-lib-v6 branch December 21, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dbhynds