forked from 1EdTech/lti-1-3-php-library
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage #125
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bda6925
Up code coverage
dbhynds d6463ee
test group sets
dbhynds 5d97afd
Add a bunch of tests
dbhynds fc16bf2
finish testing grade
dbhynds 1d45eab
Cover a few more lines
dbhynds 5db5b56
Merge branch 'v6.0-beta' into v6-code-coverage
dbhynds 011af76
add a few more tests
dbhynds c94b94b
add a few more tests
dbhynds 65e528b
add a few more tests
dbhynds 53ef41d
add another tests
dbhynds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
<?php | ||
|
||
namespace Tests; | ||
|
||
use Packback\Lti1p3\Lti1p1Key; | ||
|
||
class Lti1p1KeyTest extends TestCase | ||
{ | ||
public function setUp(): void | ||
{ | ||
$this->key = new Lti1p1Key(); | ||
} | ||
|
||
public function testItInstantiates() | ||
{ | ||
$this->assertInstanceOf(Lti1p1Key::class, $this->key); | ||
} | ||
|
||
public function testItGetsKey() | ||
{ | ||
$result = $this->key->getKey(); | ||
|
||
$this->assertNull($result); | ||
} | ||
|
||
public function testItSetsKey() | ||
{ | ||
$expected = 'expected'; | ||
|
||
$this->key->setKey($expected); | ||
|
||
$this->assertEquals($expected, $this->key->getKey()); | ||
} | ||
|
||
public function testItGetsSecret() | ||
{ | ||
$result = $this->key->getSecret(); | ||
|
||
$this->assertNull($result); | ||
} | ||
|
||
public function testItSetsSecret() | ||
{ | ||
$expected = 'expected'; | ||
|
||
$this->key->setSecret($expected); | ||
|
||
$this->assertEquals($expected, $this->key->getSecret()); | ||
} | ||
|
||
public function testItSigns() | ||
{ | ||
$key = new Lti1p1Key([ | ||
'key' => 'foo', | ||
'secret' => 'bar', | ||
]); | ||
|
||
$actual = $key->sign('deploymentId', 'iss', 'clientId', 'exp', 'nonce'); | ||
|
||
$this->assertEquals('1Ze6akG0koOVeizCVBIyQHJ78Eo3vGUXyqOM0iDqS0k=', $actual); | ||
} | ||
} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a tests for
Lti1p1Key::sign()
?