Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in launch #126

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix errors in launch #126

merged 1 commit into from
Dec 21, 2023

Conversation

dbhynds
Copy link
Member

@dbhynds dbhynds commented Dec 21, 2023 •
edited
Loading

Summary of Changes

Make a few final adjustments to our interfaces after testing changes on our platform.

Here's a passing CI pipeline using this branch: https://gitlab.com/packback/questions/-/pipelines/1114960359

Testing

  • I have added automated tests for my changes
  • I ran composer test before opening this PR
  • I ran composer lint-fix before opening this PR

@dbhynds dbhynds requested a review from lin-brian-l December 21, 2023 18:00
Base automatically changed from final-changes to v6.0-beta December 21, 2023 19:22
@dbhynds dbhynds merged commit 8b84a10 into v6.0-beta Dec 21, 2023
4 checks passed
@dbhynds dbhynds deleted the v6-bugfixes branch December 21, 2023 19:23
@dbhynds dbhynds mentioned this pull request Dec 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lin-brian-l lin-brian-l lin-brian-l approved these changes

Assignees

@lin-brian-l lin-brian-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbhynds @lin-brian-l