fix(Copr): Handle built_packages being null

The API definition did not take `null` for `built_packages` and thus never showed an issue with the code. This change fixes both the type and the issue itself.
packit · Nov 18, 2024 · bf6b2dd · bf6b2dd
1 parent 6db9ab2
commit bf6b2dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/frontend/src/apiDefinitions.ts b/frontend/src/apiDefinitions.ts
@@ -112,7 +112,7 @@ export interface CoprBuild {
   build_logs_url: string;
   build_start_time: number;
   build_submitted_time: number;
-  built_packages: CoprBuildPackage[];
+  built_packages: CoprBuildPackage[] | null;
   chroot: string;
   commit_sha: string;
   copr_owner: string;

diff --git a/frontend/src/components/copr/CoprBuild.tsx b/frontend/src/components/copr/CoprBuild.tsx
@@ -36,7 +36,8 @@ export const CoprBuild = () => {
   const [packagesToInstall, setPackagesToInstall] = useState<string[]>([]);
 
   useEffect(() => {
-    if (data) setPackagesToInstall(getPackagesToInstall(data.built_packages));
+    if (data?.built_packages)
+      setPackagesToInstall(getPackagesToInstall(data.built_packages));
   }, [data?.built_packages]);
 
   // If backend API is down