Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff #806

Merged
merged 16 commits into from
Oct 12, 2023
Merged

Ruff #806

merged 16 commits into from
Oct 12, 2023

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Sep 24, 2023 •
edited
Loading

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c5a38afb88da4dc7a28cac9c1b32154a

❌ pre-commit NODE_FAILURE Node request 200-0006421898 failed in 0s
❌ ogr-tests-rpm NODE_FAILURE Node request 200-0006421899 failed in 0s
❌ ogr-tests-pip-deps NODE_FAILURE Node request 200-0006421900 failed in 0s
❌ ogr-reverse-dep-packit-tests NODE_FAILURE Node request 200-0006421901 failed in 0s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3c242e04af8b4fb8828b17bf4fc08cb8

❌ pre-commit NODE_FAILURE Node request 200-0006422335 failed in 0s
❌ ogr-tests-rpm NODE_FAILURE Node request 200-0006422336 failed in 0s
❌ ogr-tests-pip-deps NODE_FAILURE Node request 200-0006422337 failed in 0s
❌ ogr-reverse-dep-packit-tests NODE_FAILURE Node request 200-0006422338 failed in 0s

@mfocko
Copy link
Member Author

mfocko commented Sep 24, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/7906d1d0cc6344cd890ac670648f10df

❌ pre-commit NODE_FAILURE Node request 200-0006422381 failed in 0s
❌ ogr-tests-rpm NODE_FAILURE Node request 200-0006422382 failed in 0s
❌ ogr-tests-pip-deps NODE_FAILURE Node request 200-0006422383 failed in 0s
❌ ogr-reverse-dep-packit-tests NODE_FAILURE Node request 200-0006422384 failed in 0s

jpopelka
jpopelka approved these changes Sep 25, 2023
View reviewed changes
ruff.toml Outdated Show resolved Hide resolved
@jpopelka
Copy link
Member

I've remembered that that's still #696 and #723 which are also AFAIR about adding more Optional to the code (as your last commit does). I don't quite remember the issues why we haven't finished the #723 but can you please double-check that your last commit doesn't somehow hit the same problems?

@mfocko mfocko mentioned this pull request Oct 9, 2023
Merged
@mfocko
ci: add ruff
00a7140 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable flake8-bugbear
4bc7645 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable flake8-comprehensions
0dfefb7 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable flake8-commas
11459d4 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable rules without changes
59bf798 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable isort
708f894 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable flake8-pie
6bfb367 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable flake8-return
6ceebdd 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable flake8-simplify
f16f117 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable flake8-pytest-style
98d40bf 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable pyupgrade
2cd1c6a 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci: disable pre-commit's flake8 and pyupgrade
4edd370 
They are included with the ruff, there is no need to have duplicit
checks that take more time than the whole ruff suite itself.

Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): enable the perflint and ruff rules
ce9655d 
* enable the performance rules in ruff
* enable the Ruff-specific rules in ruff
* disable check for ambiguous characters in comments; I intend to use
  guillemets

Signed-off-by: Matej Focko <[email protected]>
@mfocko
ci(ruff): remove unnecessary ignores
441f4c1 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
Copy link
Member Author

mfocko commented Oct 12, 2023

I've remembered that that's still #696 and #723 which are also AFAIR about adding more Optional to the code (as your last commit does). I don't quite remember the issues why we haven't finished the #723 but can you please double-check that your last commit doesn't somehow hit the same problems?

Had a look, tl;dr:

  • Optional has been added to some places where it doesn't make much sense, like PR ID was to be wrapped in Optional just because of what gets returned from the dependency :/
  • failing requre tests…

I'll go through the changes to check it here, but I doubt it either includes the errors or supersedes the PR :/

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/dde3bb4e8cea4243b30484cce21c6ecc

✔️ pre-commit SUCCESS in 2m 14s
❌ ogr-tests-pip-deps FAILURE in 12m 12s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9e90c9600cfe446396d1f5f322fe1522

✔️ pre-commit SUCCESS in 2m 16s
✔️ ogr-tests-pip-deps SUCCESS in 10m 51s

@mfocko mfocko self-assigned this Oct 12, 2023
@mfocko mfocko added the mergeit When set, zuul wil gate and merge the PR. label Oct 12, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4774e74c58c1456dac01eba667fad6a2

✔️ pre-commit SUCCESS in 2m 36s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 346e911 into packit:main Oct 12, 2023
27 checks passed
@mfocko mfocko deleted the ruff branch October 12, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

Assignees

@mfocko mfocko

Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfocko @jpopelka