refactor: PHPStan max level > Fix 'Property does not accept null'

pact-foundation · Sep 30, 2024 · 81bb236 · 81bb236
1 parent 74c3599
commit 81bb236
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/PhpPact/Xml/XmlElement.php b/src/PhpPact/Xml/XmlElement.php
@@ -34,7 +34,10 @@ public function __construct(callable ...$options)
 
     public function setName(string $name): self
     {
-        $this->name = preg_replace('/(^[0-9]+|[^a-zA-Z0-9\-\_\:]+)/', '', $name);
+        if (preg_match('/^[0-9]+|[^a-zA-Z0-9\-\_\:]+/', $name) !== 0) {
+            throw new InvalidXmlElementException("Xml element's name is invalid");
+        }
+        $this->name = $name;
 
         return $this;
     }