Feat/ffi consumer #366
Closed
Feat/ffi consumer #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e changes to docker37 which I will need to do to all
…e changes to docker37 which I will need to do to all
…ing by the tox list)
The return code is straightforward, but having problems with the logging. When setting up the FFI objects etc, it doesn't seem to work unless it's a basically a singleton, it seems hard to split up. I don't like it but going with this for now :)
…fi_free_string to cleanup
TODO
- Message Metadata Content-Type hardcoded to application/json
- Allow switching between rust/ruby core whilst in beta
Notes
- Message HTTP proxy needs to drop `contents`
most likely due to container, see workaround in GHA
use area calculator proto example matching up with other pact grpc examples. Pact is precreated and not currently generated from pact-python
seems to causing hanging tests on windows
|
superseded by #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pact python consumer test examples using the PactFFI lib
these are using direct calls to the ffi library so need wrapping in the Pact or Consumer dsl in pact-python
contributors welcome. this is your chance to propose a potential redesign to the pact python dsl if it isn’t quite right at the moment.
if not, hopefully connecting the dots should be a bit simpler :)
builds on #357 which introduces the ffi libs and verifier side now built out to use near enough the same dsl
tox doesn’t like my import of the area_calculator_client, it’s okay with pytest directly.