fix: ISO 8601 incompatibility #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
======================================
+ Coverage 59% 78% +18%
======================================
Files 30 30
Lines 3366 3366
======================================
+ Hits 2017 2636 +619
+ Misses 1349 730 -619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JP-Ellis
force-pushed
the
fix/iso-8601-compat
branch
from
1c55bb9
to
cea110c
Compare
There were some inconsistencies in the handling of ISO 8601 datetime values across Python versions and Pact implementations. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
fix/iso-8601-compat
branch
from
cea110c
to
d4e3519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Expand support for ISO-8601 dates
🚨 Breaking Changes🔥 Motivation
There were some inconsistencies in the handling of ISO 8601 datetime values across Python versions and Pact implementations.
🔨 Test Plan
CI
🔗 Related issues/PRs
None