fix: set correct Accept header when publishing provider contracts

pact-foundation · Oct 25, 2023 · abc8ea3 · abc8ea3
1 parent a174023
commit abc8ea3
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/doc/pacts/markdown/Pact Broker Client - Pactflow.md b/doc/pacts/markdown/Pact Broker Client - Pactflow.md
@@ -210,7 +210,7 @@ Upon receiving **a request to publish a provider contract** from Pact Broker Cli
   "path": "/HAL-REL-PLACEHOLDER-PF-PUBLISH-PROVIDER-CONTRACT-Bar",
   "headers": {
     "Content-Type": "application/json",
-    "Accept": "application/hal+json"
+    "Accept": "application/hal+json,application/problem+json"
   },
   "body": {
     "pacticipantVersionNumber": "1",

diff --git a/lib/pactflow/client/provider_contracts/publish.rb b/lib/pactflow/client/provider_contracts/publish.rb
@@ -39,7 +39,7 @@ def disabled?
         end
 
         def publish_provider_contracts
-          @response_entity = index_resource._link(PUBLISH_RELATION).expand(provider: provider_name).post!(contract_params, headers: { "Accept" => "application/hal+json,application/problem+json" })
+          @response_entity = index_resource._link(PUBLISH_RELATION).expand(provider: provider_name).post!(contract_params, { "Accept" => "application/hal+json,application/problem+json" })
         end
 
         def contract_params

diff --git a/script/publish-provider-contract.sh b/script/publish-provider-contract.sh
@@ -6,7 +6,6 @@ bundle exec bin/pactflow publish-provider-contract  \
   --branch main \
   --tag dev \
   --specification oas \
-  --content-type application/yml \
   --verification-exit-code 0 \
   --verification-results script/verification-results.txt \
   --verification-results-content-type text/plain \

diff --git a/spec/pacts/pact_broker_client-pactflow.json b/spec/pacts/pact_broker_client-pactflow.json
@@ -43,7 +43,7 @@
         "path": "/HAL-REL-PLACEHOLDER-PF-PUBLISH-PROVIDER-CONTRACT-Bar",
         "headers": {
           "Content-Type": "application/json",
-          "Accept": "application/hal+json"
+          "Accept": "application/hal+json,application/problem+json"
         },
         "body": {
           "pacticipantVersionNumber": "1",

diff --git a/spec/service_providers/pactflow_publish_provider_contract_spec.rb b/spec/service_providers/pactflow_publish_provider_contract_spec.rb
@@ -123,7 +123,7 @@
         .with(
             method: :post,
             path: placeholder_path("pf:publish-provider-contract", ["Bar"]),
-            headers: post_request_headers,
+            headers: post_request_headers.merge("Accept" => "application/hal+json,application/problem+json"),
             body: request_body
         ).will_respond_with(success_response)
     end