fix: correctly escape expanded URL links

pact-foundation · Jun 13, 2018 · d6dbce8 · d6dbce8
1 parent 415d9d5
commit d6dbce8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/pact_broker/client/hal/link.rb b/lib/pact_broker/client/hal/link.rb
@@ -57,7 +57,7 @@ def wrap_response(http_response)
         def expand_url(params, url)
           new_url = url
           params.each do | key, value |
-            new_url = new_url.gsub('{' + key.to_s + '}', value)
+            new_url = new_url.gsub('{' + key.to_s + '}', URI.escape(value))
           end
           new_url
         end

diff --git a/spec/lib/pact_broker/client/hal/link_spec.rb b/spec/lib/pact_broker/client/hal/link_spec.rb
@@ -98,6 +98,10 @@ module Hal
         it "returns a duplicate Link with the expanded href" do
           expect(subject.expand(bar: 'wiffle').href).to eq "http://foo/wiffle"
         end
+
+        it "returns a duplicate Link with the expanded href with URL escaping" do
+          expect(subject.expand(bar: 'wiffle meep').href).to eq "http://foo/wiffle%20meep"
+        end
       end
     end
   end