Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Update Team Plasma battle theme to B2W2 version #5238

Open
wants to merge 6 commits into
base: beta
Choose a base branch
from

Conversation

Madmadness65
Copy link
Collaborator

@Madmadness65 Madmadness65 commented Feb 2, 2025

What are the changes the user will see?

Replaces the basic BW Team Plasma battle theme with the B2W2 version.

Why am I making these changes?

Due to the effort to make Team Plasma fully their B2W2 counterparts via #5218 and #5224 , a replacement track was also necessary to go along with it.

What are the changes from a developer perspective?

Replaced audio file, altered loop point. No other changes are needed.

Screenshots/Videos

(Don't mind that the grunt sprites are still the BW versions, #5218 has not been merged yet)

team.plasma.mp4

How to test the changes?

Battle a Team Plasma grunt.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    - [ ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    - [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Relates to the SFX or BGM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants