[Ability] Ignore Held Items for Stat Calculation

[geeilhan]

Fixes issue mentioned in #289

What are the changes the user will see?

Quark Drive and Protosynthesis now increase correct stat.

Why am I making these changes?

What are the changes from a developer perspective?

Both Abilities used the getEffectiveStat function which could not ignore held items. (Wiki-Link)

I added another non-mandatory input to getEffectiveStat and getStatStageMultiplier which makes it possible to ignore stat changes from items (e.g. X Speed).

Screenshots/Videos

Deactive and Active Quark Drive test with Mew with X Speed (should increase ATK since X Speed is ignored and all stats are the same value):

quark-drive-test-after.webm

Same tests with harsh sunlight and Protosynthesis:

protosynthesis-test-after.webm

How to test the changes?

npm run test passes.

Also tested the implementations manually with Mew (all same stats), Ramparados and Shuckle and the stats increased correctly after the conditions for the abilities to activate are met.
In addition, I tested the Abilities effects with held items such as X ATK, and X SPEED and the stat increases worked correctly.

Currently struggling writing automated tests.
I tried using vi.spyon(player, "getEffectiveStat") but this does not work. Just using expect(player.getEffectiveStat(Stat.ATK)).toBe([Value]) also did not work.
-> Still working on the tests. Maybe just reading the damage numbers directly might work.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

[damocleas]

Works as intended based off of stat changes and x items etc, need a dev to review

[DayKev]

Code looks good, needs automated tests then it's good to go.

[SirzBenjie]

I added a unit test for this, but I can't suggest it here and I seem to be lacking the ability to do a PR for geeilhan's repo
https://github.com/SirzBenjie/pokerogue/tree/ignorehelditem-stat-implementation

[DayKev]

Seems like the test might be flaky. Re-ran it locally and it passed.

[geeilhan]

Seems like the test might be flaky. Re-ran it locally and it passed.

That is weird. It previously failed because of the nature but it should work fine now.

[SirzBenjie]

Mew's base stats were being changed by nature. I did an override to set the nature and I no longer observed an inconsistency across a dozen runs.
Unless starting IVs are also randomized?

[DayKev]

IVs shouldn't be random, last I checked they were consistent between test runs.

[SirzBenjie]

IVs shouldn't be random, last I checked they were consistent between test runs.

Huh. It looks like the test failed after the nature change (unless actions messed up). Is it still non deterministic?

[DayKev]

Ran the test a bunch and when it failed the Magikarp moved before Mew on the first turn.

[SirzBenjie]

Oh I didn't do a turn order override?

I should probably fix that.

[geeilhan]

Oh I didn't do a turn order override?

I should probably fix that.

Added turnorder to tests

[DayKev]

Oh it looks like you made the same change in #4984, could you merge the changes to Tera Blast from there to this PR?

[geeilhan]

Oh it looks like you made the same change in #4984, could you merge the changes to Tera Blast from there to this PR?

Added Tera Blast Changes