Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Pokedex updates batch #5282

Merged
merged 26 commits into from
Feb 11, 2025
Merged

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Feb 8, 2025

This PR includes various additions and bug fixes for the internal dex. In particular:

  • In the main page, the F button is now used to display form icons whenever possible.
  • The dexForDevs option now displays full unlocks in the main page as expected.
  • Passive abilities and abilities of alternate forms were not filtered properly, this is now fixed.
  • Pikachu was crashing the game due to not having a passive, this is now fixed.
  • Candy upgrades can be bought even when looking at evolutions and forms.
  • Species that were previously treated as evolved starters now properly display egg moves
  • Selecting the pokedex option from the starter select screen now does not play the error sound
  • If a mon has no TM moves, selecting the option in the dex page shows an error message.
  • The menu in the pokedex page is positioned properly for localized text
  • Removed a spurious line that cleared phases when exiting the dex, causing a variety of bugs in battle
  • Dark icons when filtering egg moves and passives which are not unlocked

Screenshots/Videos

Showing forms in the main page

Pokerogue.Mozilla.Firefox.2025-02-08.23-22-21.mp4

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

@Madmadness65 Madmadness65 added the UI/UX User interface/-experience related label Feb 8, 2025
src/ui/pokedex-mon-container.ts Show resolved Hide resolved
src/ui/pokedex-page-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/pokedex-page-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/pokedex-page-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/pokedex-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/pokedex-ui-handler.ts Show resolved Hide resolved
src/ui/pokedex-ui-handler.ts Outdated Show resolved Hide resolved
@Wlowscha
Copy link
Contributor Author

Wlowscha commented Feb 9, 2025

lunala_upgrades

Candy upgrades can now be bought for evolutions, unavailable options are shown in shadowed text

@Wlowscha Wlowscha marked this pull request as ready for review February 9, 2025 02:04
@Wlowscha Wlowscha requested a review from a team as a code owner February 9, 2025 02:04
Madmadness65
Madmadness65 previously approved these changes Feb 9, 2025
@Snailman11
Copy link
Collaborator

Link to Discord's Bug report (Pokedex issue (Beta))
https://discord.com/channels/1125469663833370665/1338018434537230367

Madmadness65
Madmadness65 previously approved these changes Feb 10, 2025
@Wlowscha
Copy link
Contributor Author

Fixed a bug documented in this discord thread, exiting the dex would refresh the phase queue which is unwanted behavior. Seems to be working fine now:

Pokerogue.Mozilla.Firefox.2025-02-10.18-59-11.mp4
Pokerogue.Mozilla.Firefox.2025-02-10.19-00-35.mp4

@Wlowscha
Copy link
Contributor Author

Also, clicking the TM moves option now shows an error message if no TMs are available:

Pokerogue.Mozilla.Firefox.2025-02-10.19-12-16.mp4

@Wlowscha
Copy link
Contributor Author

While filtering, icons are displayed next to the mon if the move being filtered is an egg move, or if the ability is a passive. The icons are now darkened if the respective egg move or passive is not unlocked. Colored candy icons for passives have been removed to avoid confusion.

Pokerogue.Mozilla.Firefox.2025-02-10.19-35-05.mp4
Pokerogue.Mozilla.Firefox.2025-02-10.19-45-21.mp4

@DayKev DayKev added P1 Bug Major. Game crashing move/ability/interaction P2 Bug Minor. Non crashing Incorrect move/ability/interaction P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. labels Feb 11, 2025
@DayKev DayKev merged commit 60b27f4 into pagefaultgames:beta Feb 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Bug Major. Game crashing move/ability/interaction P2 Bug Minor. Non crashing Incorrect move/ability/interaction P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants