Improved Preact integration #1
Open
+3,488
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preact offers a plugin system that enables us to tap into certain parts of it.
We leverage the `vnode` event to `wrap` any function component into a Reactive Component.
This integration removes the need to configure the JSX factory or importSource when using `@pago/reactive` with Preact.
To enable the behaviour, the user will have to either:
Option A:
Use a side effect import to install the Preact plugin.
```
import "@pago/reactive/preact";
```
Option B:
Use `@pago/reactive/preact` instead of `@pago/reactive` when importing any function.
```
import { ref } from "@pago/reactive/preact";
```
Option C:
Configure an alias from `@pago/reactive` to `@pago/reactive/preact`.
pago
commented
Nov 27, 2020
| import { wrap } from '../'; | ||
| export * from '../'; | ||
|
|
||
| const map = new WeakMap(); |
There was a problem hiding this comment.
tsdx is limiting me a bit too much when setting up additional entry points. Need to drop it at some point.
For now I manually copied the code for the ESM and CJS version. But that's basically the integration with Preact.
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preact offers a plugin system that enables us to tap into certain parts of it.
We leverage the
vnodeevent towrapany function component into a Reactive Component.This integration removes the need to configure the JSX factory or importSource when using
@pago/reactivewith Preact.To enable the behaviour, the user will have to either:
Option A:
Use a side effect import to install the Preact plugin.
Option B:
Use
@pago/reactive/preactinstead of@pago/reactivewhen importing any function.Option C:
Configure an alias from
@pago/reactiveto@pago/reactive/preact.Question
Is this type of integration preferable over configuring the
jsxImportSource? Or would it be preferable to stick to one-size fits all and have the same type of integration for React and Preact with no special casing for now?