Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-1798] Fix api header highlight #1149

Merged
merged 7 commits into from
Sep 25, 2024
Merged

[DEV-1798] Fix api header highlight #1149

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
284b925
add apidataslug to path
MarBert Sep 23, 2024
2fe6414
add changeset
MarBert Sep 23, 2024
eeb0afe
update changeset
MarBert Sep 23, 2024
4686d86
Merge branch 'main' into DEV-1798-fix-api-highlight
MarBert Sep 23, 2024
835a7e0
Update apps/nextjs-website/src/app/[productSlug]/api/[apiDataSlug]/pa…
MarBert Sep 24, 2024
971000a
Update .changeset/old-plums-joke.md
MarBert Sep 24, 2024
cf7d61c
Merge branch 'main' into DEV-1798-fix-api-highlight
marcobottaro Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-plums-joke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"nextjs-website": patch
---

Fixed product layout path for api page
MarBert marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 2 additions & 1 deletion apps/nextjs-website/src/app/[productSlug]/api/[apiDataSlug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@ export const generateMetadata = async (
const ApiDataPage = async ({ params }: ApiDataParams) => {
const apiDataProps = await getApiData(params.apiDataSlug);
const product = await getProduct(params.productSlug);
const path = product?.path + '/api/' + params.apiDataSlug;
if (apiDataProps && product) {
MarBert marked this conversation as resolved.
Show resolved Hide resolved
return (
<ProductLayout
product={product}
path={product.path.concat('/api')}
path={path}
bannerLinks={product.bannerLinks || apiDataProps.bannerLinks}
showBreadcrumbs
>
Expand Down
Loading