Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-1972] Remove hardcoded content #1196

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Conversation

tommaso1
Copy link
Collaborator

List of Changes

Removes every static content, relying only on strapi

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

marcobottaro and others added 27 commits September 20, 2024 16:57
…duct-codec

# Conflicts:
#	apps/nextjs-website/src/lib/strapi/__tests__/quickStartGuides.test.ts
#	apps/nextjs-website/src/lib/strapi/__tests__/tutorials.test.ts
#	apps/nextjs-website/src/lib/strapi/codecs/GuidesCodec.ts
#	apps/nextjs-website/src/lib/strapi/codecs/OverviewsCodec.ts
#	apps/nextjs-website/src/lib/strapi/codecs/TutorialListPagesCodec.ts
#	apps/nextjs-website/src/lib/strapi/fetches/fetchGuideListPages.ts
#	apps/nextjs-website/src/lib/strapi/fetches/fetchHomepage.ts
#	apps/nextjs-website/src/lib/strapi/fetches/fetchQuickStartGuides.ts
Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 41d891d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Branch is not up to date with base branch

@MarcoPonchia it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-1972

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This PR exceeds the recommended size of 800 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 76.28 KB (🟡 +18 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants