Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAI-198] - Chatbot Languages #1206

Merged
merged 9 commits into from
Oct 23, 2024
Merged

[CAI-198] - Chatbot Languages #1206

merged 9 commits into from
Oct 23, 2024

Conversation

mdciri
Copy link
Collaborator

@mdciri mdciri commented Oct 17, 2024

List of Changes

  • Add minor languages to presisio
  • Now the chatbot should only reply in Italian

Motivation and Context

privacy and UI reasons

How Has This Been Tested?

jupyter notebook

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mdciri mdciri requested a review from a team as a code owner October 17, 2024 10:04
Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: d4222f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mdciri mdciri changed the title Languages/chatbot/cai 198 [CAI-198] - Chatbot Languages Oct 17, 2024
ITALIAN_THRESHOLD = 0.85
NUM_MIN_WORDS_QUERY = 3
NUM_MIN_REFERENCES = 1
USE_PRESIDIO = True if os.getenv("CHB_USE_PRESIDIO", "True") == "True" else False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid issue with capital letters I would lower the env variable

Suggested change
USE_PRESIDIO = True if os.getenv("CHB_USE_PRESIDIO", "True") == "True" else False
USE_PRESIDIO = True if lower(os.getenv("CHB_USE_PRESIDIO", "True")) == "true" else False

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here and in src/modules/engine.py.

the method lower() goes after the string. lower(string) does not work; string.lower() works.

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue CAI-198

@mdciri mdciri merged commit abf8839 into main Oct 23, 2024
11 checks passed
@mdciri mdciri deleted the languages/chatbot/cai-198 branch October 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants