[DEV-2004] fix headers sequence #1287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarBert
requested review from
MarcoPonchia,
marcobottaro and
tommaso1
as code owners
🦋 Changeset detectedLatest commit: 1b8921e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch is not up to date with base branch@MarBert it seems this Pull Request is not updated with base branch. |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2004 |
|
Bundle not found for branch |
marcobottaro
requested changes
Dec 20, 2024
Comment on lines
+70
to
+75
| sx={{ | ||
| ...titleStyle, | ||
| fontSize: '1.5rem !important', | ||
| lineHeight: '1.15 !important', | ||
| }} | ||
| mt={2} |
There was a problem hiding this comment.
Maybe you shoud move all styles inside sx attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
headers are now in sequence
Motivation and Context
overview and tutorials had h1 -> h4 -> h6 instead h1 -> h2 -> h3 (for SEO)
How Has This Been Tested?
localhost
Screenshots (if appropriate):
Types of changes
Checklist: