Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-2002] abstract header update to h1 #1288

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

MarBert
Copy link
Collaborator

@MarBert MarBert commented Dec 20, 2024

List of Changes

Update variant of typography in Abstract.tsx to h1, keeping original text style

Motivation and Context

The original variant created issue with SEO

How Has This Been Tested?

on Localhost

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: dc7640e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-2002

Copy link
Contributor

github-actions bot commented Jan 9, 2025

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 76.26 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@marcobottaro marcobottaro merged commit 50111b7 into main Jan 9, 2025
12 checks passed
@marcobottaro marcobottaro deleted the DEV-2002-abstract-to-h1 branch January 9, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants