[DEV-1465] Reset login form errors on user changes #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremygordillo
requested review from
MarcoPonchia,
marcobottaro,
tommaso1 and
a team
as code owners
🦋 Changeset detectedLatest commit: e05da1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
datalek
reviewed
Feb 29, 2024
apps/nextjs-website/src/__tests__/components/LoginForm.test.tsx
Outdated
Show resolved
Hide resolved
marcobottaro
requested changes
Mar 8, 2024
Co-authored-by: marcobottaro <[email protected]>
tommaso1
approved these changes
Mar 11, 2024
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-1465 |
📦 Next.js Bundle Analysis for nextjs-websiteThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for nextjs-websiteThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
marcobottaro
approved these changes
Mar 11, 2024
MikeAtUqido
pushed a commit
that referenced
this pull request
Mar 13, 2024
* refactor login form * handle reset errors on change input value * add LoginForm tests * add test * Create sour-penguins-smile.md * Moved test file * fix error prop value * improve test * pr changes * minor fixes * changes after review * Update .changeset/sour-penguins-smile.md Co-authored-by: marcobottaro <[email protected]> --------- Co-authored-by: marcobottaro <[email protected]>
MarcoPonchia
added a commit
that referenced
this pull request
Mar 15, 2024
* feat(DEV-1437): change subscribe button click logic * chore: add changeset * feat(DEV-1437): use router.push instead of router.replace * feat(DEV-1347): refact code to subscribe after user login * chore: update changeset Co-authored-by: marcobottaro <[email protected]> * feat(DEV-1347): refact code to subscribe after user login * [DEV-1433]: display hero from Strapi (#672) * feat(DEV-1433): display hero from Strapi * feat(DEV-1433): update test * chore: add changeset * feat(DEV-1433): update test * feat(DEV-1433): update code * feat(DEV-1433): update codecs names * feat(DEV-1433): fix codec bugs * feat(DEV-1433): add test * feat(DEV-1433): fix tests * chore: remove console.log Co-authored-by: AF <[email protected]> * feat(DEV-1433): simplify logic Co-authored-by: AF <[email protected]> * [DEV-1342] Remove email in url (#663) * Remove email in url * eslint * changeset * pr comment --------- Co-authored-by: marcobottaro <[email protected]> * Do not fetch from cache when executing deploy website workflow (#699) * Update CHANGELOG and prepare next release (#682) * Fix pagoPA guides and manuals version (#700) * Revert "Fix pagoPA guides and manuals version (#700)" (#701) This reverts commit 17ef179. * [DPC-160] Fix pagoPA guides and manuals version (#702) * Update CHANGELOG and prepare next release (#703) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix typo * Add NullToUndefined custom type * feat(DEV-1433): simplify logic Co-authored-by: AF <[email protected]> * feat(DEV-1433): add explanatory comment --------- Co-authored-by: AF <[email protected]> Co-authored-by: marcobottaro <[email protected]> Co-authored-by: tommaso1 <[email protected]> Co-authored-by: Marco Comi <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Marco Ponchia <[email protected]> Co-authored-by: Marco Bottaro <[email protected]> * [DEV-1427] Move infrastructure under the monorepo structure (#720) * [DEV-1465] Reset login form errors on user changes (#692) * refactor login form * handle reset errors on change input value * add LoginForm tests * add test * Create sour-penguins-smile.md * Moved test file * fix error prop value * improve test * pr changes * minor fixes * changes after review * Update .changeset/sour-penguins-smile.md Co-authored-by: marcobottaro <[email protected]> --------- Co-authored-by: marcobottaro <[email protected]> * [DPC-175] Removes ref. to specific versions in the guide list and redirects to the latest pagoPA (#726) * [DPC-175] Removes all ref to specific versions in the guide list and redirects to the latest for pagoPA * [DPC-175] Latest version in "pagoPA Panoramica" * [DPC-175] Latest version in "pagoPA Quick Start" --------- Co-authored-by: marcobottaro <[email protected]> * [DPC-171] Removes ref. to specific version and redirects to lates in Quick Start Firma con IO (#727) Co-authored-by: marcobottaro <[email protected]> * [DEV-1503] Add googleusercontent to trusted domains (#722) * Revert "[DPC-171] Removes ref. to specific version and redirects to lates in …" (#732) * Revert "[DPC-175] Removes ref. to specific versions in the guide list and red…" (#731) This reverts commit abdb055. * [DPC-169] Removes version and redirects to latest in Panoramica App IO (#730) * [DPC-169] Removes version and redirects to latest in Panoramica App IO * [DPC-169]Removes version and redirects to latest in Webinar Description * Add changeset * [DPC-175] Removes ref. to specific versions in the guide list and redirects to the latest pagoPA (#733) * [DPC-175] Removes all ref to specific versions in the guide list and redirects to the latest for pagoPA * [DPC-175] Latest version in "pagoPA Panoramica" * [DPC-175] Latest version in "pagoPA Quick Start" --------- Co-authored-by: Monica Costantini <[email protected]> * [DPC-171] Removes specific version and redirects to lates in Quick Start Firma con IO (#734) * [DPC-171] Removes ref. to specific version and redirects to lates in Quick Start Firma con IO * [DPC-175] Removes ref. to specific versions in the guide list and redirects to the latest pagoPA (#726) * [DPC-175] Removes all ref to specific versions in the guide list and redirects to the latest for pagoPA * [DPC-175] Latest version in "pagoPA Panoramica" * [DPC-175] Latest version in "pagoPA Quick Start" --------- Co-authored-by: marcobottaro <[email protected]> --------- Co-authored-by: Monica Costantini <[email protected]> * [DPC-170] Redirects to "Validatore" SEND latest version in HomePage (#728) --------- Co-authored-by: marcobottaro <[email protected]> * [DEV-1315]: highlight and hide webinars questions (#646) * feat(DEV-1315): highlight and hide webinars questions * feat(DEV-1315): add UpdateItem to host user * chore: fix typo * feat(DEV-1315): remove definitions from terraform * chore: add changeset * feat(DEV-1358): remove unused code * feat(DEV-1315): update webinars questions' row * feat(DEV-1315): update style Co-authored-by: Marco Ponchia <[email protected]> * feat(DEV-1315): update style Co-authored-by: Marco Ponchia <[email protected]> * feat(DEV-1315): update style Co-authored-by: Marco Ponchia <[email protected]> * chore: update changeset Co-authored-by: marcobottaro <[email protected]> * feat(DEV-1315): add user names * chore: remove unused code * feat(DEV-1315): update tests * feat(DEV-1315): update code * chore: remove unused code * test: update tests * feat(DEV-1315): update logic * feat(DEV-1315): add default tcColor * feat(DEV-1315): update IconButton visibility icon Co-authored-by: Marco Ponchia <[email protected]> * feat(DEV-1315): update WebinarQuestion codec to accept undefined values * chore: remove test webinar * feat(DEV-1315): unify update question logic * chore: remove test webinar * Webinar questions review (#704) * feat(DEV-1315): update translation Co-authored-by: marcobottaro <[email protected]> --------- Co-authored-by: Marco Ponchia <[email protected]> Co-authored-by: marcobottaro <[email protected]> Co-authored-by: AF <[email protected]> Co-authored-by: Marco Comi <[email protected]> * [DEV-1448] Add concurrency in workflows that are using terraform (#735) * [DEV-1448] Add concurrency group in deploy workflows (#737) * [DPC-168] Adds cover images for new BO manual for pagoPA (#739) * [DEV-1505] Webinar tests (#729) * Update CHANGELOG and prepare next release (#718) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Move working-directory to a single step (#740) * Add changeset (#741) * Update CHANGELOG and prepare next release (#742) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(DEV-1347): redirect also the authenticated users * feat(DEV-1347): update useEffect deps --------- Co-authored-by: marcobottaro <[email protected]> Co-authored-by: AF <[email protected]> Co-authored-by: tommaso1 <[email protected]> Co-authored-by: Marco Comi <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Marco Ponchia <[email protected]> Co-authored-by: Marco Bottaro <[email protected]> Co-authored-by: Jeremy Gordillo <[email protected]> Co-authored-by: Monica Costantini <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
Reset errors of login form when user updates invalid input values
How Has This Been Tested?
Run
npm run test -w nextjs-websiteScreenshots (if appropriate):
Types of changes
Checklist: