CI and various fixes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Carminepo2
commented
Jul 19, 2024
•
Carminepo2
commented
- Added encoding and decoding function for each domain;
- Fix event schema, added missing properties;
- Fix CI and added npm release;
Carminepo2
requested review from
micdes-pagopa,
beetlecrunch,
galales,
AsterITA and
taglioni-r
as code owners
taglioni-r
reviewed
Jul 29, 2024
.eslintrc.cjs
Outdated
| @@ -21,4 +21,4 @@ module.exports = { | |||
| "@typescript-eslint/no-use-before-define": "off", | |||
| }, | |||
| ignorePatterns: [".eslintrc.cjs", "**/src/gen/**/*.ts", "**/dist"], | |||
| }; | |||
| }; | |||
taglioni-r
reviewed
Jul 29, 2024
proto/v2/tenant/events.proto
Outdated
| message TenantKindUpdatedV2 { | ||
| TenantKindV2 oldKind = 1; | ||
| TenantV2 tenant = 2; | ||
| } |
taglioni-r
approved these changes
Jul 29, 2024
beetlecrunch
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.