feat: [IOPLT-724] Split up the backend status for better handling (#6296

) ## Short description This PR aims to split the `backendStatus` reducer and store section into 4 different reducers ## List of changes proposed in this pull request - Removed `backendStatus` reducer - Created `remoteConfig`, `sectionStatus`, `backendInfo`, `statusMessages` reducers ## How to test Anything should work properly as usual after changes. --------- Co-authored-by: Andrea <[email protected]>
pagopa · Nov 5, 2024 · 1b07349 · 1b07349
1 parent 0881665
commit 1b07349
Show file tree

Hide file tree

Showing 125 changed files with 1,144 additions and 1,443 deletions.
diff --git a/ts/components/SectionStatus/__tests__/index.test.tsx b/ts/components/SectionStatus/__tests__/index.test.tsx
@@ -5,14 +5,13 @@ import configureMockStore from "redux-mock-store";
 import { IOColors } from "@pagopa/io-app-design-system";
 import * as pot from "@pagopa/ts-commons/lib/pot";
 import { ToolEnum } from "../../../../definitions/content/AssistanceToolConfig";
-import { BackendStatus } from "../../../../definitions/content/BackendStatus";
 import { Config } from "../../../../definitions/content/Config";
 import {
   LevelEnum,
   SectionStatus
 } from "../../../../definitions/content/SectionStatus";
 import I18n, { setLocale } from "../../../i18n";
-import { SectionStatusKey } from "../../../store/reducers/backendStatus";
+import { SectionStatusKey } from "../../../store/reducers/backendStatus/sectionStatus";
 import { renderScreenWithNavigationStoreContext } from "../../../utils/testWrapper";
 import { openWebUrl } from "../../../utils/url";
 import SectionStatusComponent from "../index";
@@ -22,6 +21,7 @@ import { TrialSystemState } from "../../../features/trialSystem/store/reducers";
 import { PersistedFeaturesState } from "../../../features/common/store/reducers";
 import { ItwLifecycleState } from "../../../features/itwallet/lifecycle/store/reducers";
 import { ItWalletState } from "../../../features/itwallet/common/store/reducers";
+import { GlobalState } from "../../../store/reducers/types";
 
 jest.mock("../../../utils/url");
 
@@ -40,41 +40,38 @@ const sectionStatus: SectionStatus = {
 
 const mockSectionStatusState = (
   sectionKey: SectionStatusKey,
-  sectionStatus: SectionStatus
-) => ({
-  backendStatus: {
-    status: O.some({
-      sections: { [sectionKey]: sectionStatus },
-      config: {
-        assistanceTool: { tool: ToolEnum.none },
-        cgn: { enabled: true },
-        newPaymentSection: {
-          enabled: false,
-          min_app_version: {
-            android: "0.0.0.0",
-            ios: "0.0.0.0"
-          }
-        },
-        fims: { enabled: true },
-        itw: {
-          enabled: true,
-          min_app_version: {
-            android: "0.0.0.0",
-            ios: "0.0.0.0"
-          }
+  status: SectionStatus
+) =>
+  ({
+    sectionStatus: O.some({ [sectionKey]: status }),
+    remoteConfig: O.some({
+      assistanceTool: { tool: ToolEnum.none },
+      cgn: { enabled: true },
+      newPaymentSection: {
+        enabled: false,
+        min_app_version: {
+          android: "0.0.0.0",
+          ios: "0.0.0.0"
         }
-      } as Config
-    } as BackendStatus)
-  },
-  features: {
-    itWallet: {
-      lifecycle: ItwLifecycleState.ITW_LIFECYCLE_INSTALLED
-    } as ItWalletState
-  } as PersistedFeaturesState,
-  trialSystem: {
-    [itwTrialId]: pot.some(SubscriptionStateEnum.UNSUBSCRIBED)
-  } as TrialSystemState
-});
+      },
+      fims: { enabled: true },
+      itw: {
+        enabled: true,
+        min_app_version: {
+          android: "0.0.0.0",
+          ios: "0.0.0.0"
+        }
+      }
+    } as Config),
+    features: {
+      itWallet: {
+        lifecycle: ItwLifecycleState.ITW_LIFECYCLE_INSTALLED
+      } as ItWalletState
+    } as PersistedFeaturesState,
+    trialSystem: {
+      [itwTrialId]: pot.some(SubscriptionStateEnum.UNSUBSCRIBED)
+    } as TrialSystemState
+  } as unknown as GlobalState);
 
 const mockStore = configureMockStore();
 
@@ -186,9 +183,8 @@ describe("Section Status Component should return null", () => {
     const component = getComponent(
       "messages",
       mockStore({
-        backendStatus: {
-          status: O.none
-        },
+        remoteConfig: O.none,
+        sectionStatus: O.none,
         trialSystem: {
           [itwTrialId]: pot.some(SubscriptionStateEnum.UNSUBSCRIBED)
         } as TrialSystemState,

diff --git a/ts/components/SectionStatus/index.tsx b/ts/components/SectionStatus/index.tsx
@@ -9,7 +9,7 @@ import {
   messageForSectionSelector,
   SectionStatusKey,
   webUrlForSectionSelector
-} from "../../store/reducers/backendStatus";
+} from "../../store/reducers/backendStatus/sectionStatus";
 import { getFullLocale } from "../../utils/locale";
 import { openWebUrl } from "../../utils/url";
 import { useIOSelector } from "../../store/hooks";

diff --git a/ts/components/SectionStatus/modal/index.tsx b/ts/components/SectionStatus/modal/index.tsx
@@ -10,7 +10,7 @@ import {
   messageForSectionSelector,
   SectionStatusKey,
   webUrlForSectionSelector
-} from "../../../store/reducers/backendStatus";
+} from "../../../store/reducers/backendStatus/sectionStatus";
 import { getFullLocale } from "../../../utils/locale";
 import { openWebUrl } from "../../../utils/url";
 import { useIOSelector } from "../../../store/hooks";

diff --git a/ts/components/screens/BaseHeader.tsx b/ts/components/screens/BaseHeader.tsx
@@ -24,7 +24,7 @@ import { useFocusEffect } from "@react-navigation/native";
 import I18n from "../../i18n";
 import { navigateBack } from "../../store/actions/navigation";
 import { Dispatch } from "../../store/actions/types";
-import { assistanceToolConfigSelector } from "../../store/reducers/backendStatus";
+import { assistanceToolConfigSelector } from "../../store/reducers/backendStatus/remoteConfig";
 import { isSearchEnabledSelector } from "../../store/reducers/search";
 import { GlobalState } from "../../store/reducers/types";
 import variables from "../../theme/variables";

diff --git a/ts/components/screens/BaseScreenComponent/__tests__/BaseScreenComponent.test.tsx b/ts/components/screens/BaseScreenComponent/__tests__/BaseScreenComponent.test.tsx
@@ -4,17 +4,16 @@ import React from "react";
 import { Store } from "redux";
 import configureMockStore from "redux-mock-store";
 import { ToolEnum } from "../../../../../definitions/content/AssistanceToolConfig";
-import { BackendStatus } from "../../../../../definitions/content/BackendStatus";
 import { Config } from "../../../../../definitions/content/Config";
 import * as zendeskActions from "../../../../features/zendesk/store/actions";
 import { applicationChangeState } from "../../../../store/actions/application";
 import { appReducer } from "../../../../store/reducers";
-import { BackendStatusState } from "../../../../store/reducers/backendStatus";
 import { GlobalState } from "../../../../store/reducers/types";
 import { renderScreenWithNavigationStoreContext } from "../../../../utils/testWrapper";
 
 import BaseScreenComponent, { Props } from "../index";
 import { MESSAGES_ROUTES } from "../../../../features/messages/navigation/routes";
+import { RemoteConfigState } from "../../../../store/reducers/backendStatus/remoteConfig";
 
 jest.useFakeTimers();
 
@@ -28,13 +27,9 @@ describe("BaseScreenComponent", () => {
   const mockStore = configureMockStore<GlobalState>();
   const state = {
     ...globalState,
-    backendStatus: {
-      status: O.some({
-        config: {
-          assistanceTool: { tool: ToolEnum.none }
-        } as Config
-      } as BackendStatus)
-    } as BackendStatusState
+    remoteConfig: O.some({
+      assistanceTool: { tool: ToolEnum.none }
+    } as Config) as RemoteConfigState
   };
 
   it.each`
@@ -49,29 +44,25 @@ describe("BaseScreenComponent", () => {
         defaultProps,
         mockStore({
           ...state,
-          backendStatus: {
-            status: O.some({
-              config: {
-                assistanceTool: { tool },
-                cgn: { enabled: true },
-                newPaymentSection: {
-                  enabled: false,
-                  min_app_version: {
-                    android: "0.0.0.0",
-                    ios: "0.0.0.0"
-                  }
-                },
-                fims: { enabled: true },
-                itw: {
-                  enabled: true,
-                  min_app_version: {
-                    android: "0.0.0.0",
-                    ios: "0.0.0.0"
-                  }
-                }
-              } as Config
-            } as BackendStatus)
-          } as BackendStatusState
+          remoteConfig: O.some({
+            assistanceTool: { tool },
+            cgn: { enabled: true },
+            newPaymentSection: {
+              enabled: false,
+              min_app_version: {
+                android: "0.0.0.0",
+                ios: "0.0.0.0"
+              }
+            },
+            fims: { enabled: true },
+            itw: {
+              enabled: true,
+              min_app_version: {
+                android: "0.0.0.0",
+                ios: "0.0.0.0"
+              }
+            }
+          } as Config) as RemoteConfigState
         })
       );
       expect(component.queryByTestId("helpButton")).toBeNull();
@@ -83,29 +74,25 @@ describe("BaseScreenComponent", () => {
       defaultProps,
       mockStore({
         ...state,
-        backendStatus: {
-          status: O.some({
-            config: {
-              assistanceTool: { tool: ToolEnum.zendesk },
-              cgn: { enabled: true },
-              newPaymentSection: {
-                enabled: false,
-                min_app_version: {
-                  android: "0.0.0.0",
-                  ios: "0.0.0.0"
-                }
-              },
-              fims: { enabled: true },
-              itw: {
-                enabled: true,
-                min_app_version: {
-                  android: "0.0.0.0",
-                  ios: "0.0.0.0"
-                }
-              }
-            } as Config
-          } as BackendStatus)
-        } as BackendStatusState
+        remoteConfig: O.some({
+          assistanceTool: { tool: ToolEnum.zendesk },
+          cgn: { enabled: true },
+          newPaymentSection: {
+            enabled: false,
+            min_app_version: {
+              android: "0.0.0.0",
+              ios: "0.0.0.0"
+            }
+          },
+          fims: { enabled: true },
+          itw: {
+            enabled: true,
+            min_app_version: {
+              android: "0.0.0.0",
+              ios: "0.0.0.0"
+            }
+          }
+        } as Config) as RemoteConfigState
       })
     );
     const helpButton = component.queryByTestId("helpButton");

diff --git a/ts/components/screens/BaseScreenComponent/index.tsx b/ts/components/screens/BaseScreenComponent/index.tsx
@@ -5,7 +5,7 @@ import { TranslationKeys } from "../../../../locales/locales";
 import { zendeskSupportStart } from "../../../features/zendesk/store/actions";
 import { useIODispatch, useIOSelector } from "../../../store/hooks";
 import { canShowHelpSelector } from "../../../store/reducers/assistanceTools";
-import { assistanceToolConfigSelector } from "../../../store/reducers/backendStatus";
+import { assistanceToolConfigSelector } from "../../../store/reducers/backendStatus/remoteConfig";
 import { currentRouteSelector } from "../../../store/reducers/navigation";
 import { FAQsCategoriesType } from "../../../utils/faq";
 import {

diff --git a/ts/components/wallet/PaymentMethodsList.tsx b/ts/components/wallet/PaymentMethodsList.tsx
@@ -21,9 +21,9 @@ import { BackendStatus } from "../../../definitions/content/BackendStatus";
 import { LevelEnum } from "../../../definitions/content/SectionStatus";
 import I18n from "../../i18n";
 import {
-  backendStatusSelector,
-  SectionStatusKey
-} from "../../store/reducers/backendStatus";
+  SectionStatusKey,
+  sectionStatusSelector
+} from "../../store/reducers/backendStatus/sectionStatus";
 import { GlobalState } from "../../store/reducers/types";
 import { getFullLocale } from "../../utils/locale";
 import { IOBadge, IOBadgeOutlineColors } from "../core/IOBadge";
@@ -78,11 +78,11 @@ export const showPaymentMethodIncomingAlert = () =>
  * if it is critical status, it returns also an alert function, undefined otherwise
  * the alert display a title (section.badge) and a message (section.message) with default dismiss button
  * @param paymentMethod
- * @param backendStatus
+ * @param sectionStatus
  */
 const getBadgeStatus = (
   paymentMethod: IPaymentMethod,
-  backendStatus: O.Option<BackendStatus>
+  sectionStatus: O.Option<BackendStatus["sections"]>
 ): null | { badge: React.ReactNode; alert?: () => void } => {
   const itemSection = paymentMethod.section;
 
@@ -97,8 +97,7 @@ const getBadgeStatus = (
     return null;
   }
   return pipe(
-    backendStatus,
-    O.chainNullableK(bs => bs.sections),
+    sectionStatus,
     O.fold(
       () => null,
       sections => {
@@ -134,11 +133,11 @@ const getBadgeStatus = (
 
 const renderListItem = (
   itemInfo: ListRenderItemInfo<IPaymentMethod>,
-  backendStatus: O.Option<BackendStatus>
+  sectionStatus: O.Option<BackendStatus["sections"]>
 ) => {
   switch (itemInfo.item.status) {
     case "implemented": {
-      const badgeStatus = getBadgeStatus(itemInfo.item, backendStatus);
+      const badgeStatus = getBadgeStatus(itemInfo.item, sectionStatus);
       return (
         <Pressable
           accessibilityRole="button"
@@ -225,7 +224,7 @@ const PaymentMethodsList: React.FunctionComponent<Props> = (props: Props) => (
   </View>
 );
 const mapStateToProps = (state: GlobalState) => ({
-  sectionStatus: backendStatusSelector(state)
+  sectionStatus: sectionStatusSelector(state)
 });
 export default connect(mapStateToProps)(
   withLightModalContext(PaymentMethodsList)

diff --git a/ts/features/barcode/components/BarcodeScanBaseScreenComponent.tsx b/ts/features/barcode/components/BarcodeScanBaseScreenComponent.tsx
@@ -31,7 +31,7 @@ import {
 } from "../../../navigation/params/AppParamsList";
 import { useIODispatch, useIOSelector } from "../../../store/hooks";
 import { canShowHelpSelector } from "../../../store/reducers/assistanceTools";
-import { assistanceToolConfigSelector } from "../../../store/reducers/backendStatus";
+import { assistanceToolConfigSelector } from "../../../store/reducers/backendStatus/remoteConfig";
 import { currentRouteSelector } from "../../../store/reducers/navigation";
 import { FAQsCategoriesType } from "../../../utils/faq";
 import { isAndroid } from "../../../utils/platform";

diff --git a/ts/features/barcode/screens/BarcodeScanScreen.tsx b/ts/features/barcode/screens/BarcodeScanScreen.tsx
@@ -22,7 +22,7 @@ import { useIODispatch, useIOSelector } from "../../../store/hooks";
 import {
   barcodesScannerConfigSelector,
   isIdPayEnabledSelector
-} from "../../../store/reducers/backendStatus";
+} from "../../../store/reducers/backendStatus/remoteConfig";
 import { emptyContextualHelp } from "../../../utils/emptyContextualHelp";
 import { useIOBottomSheetAutoresizableModal } from "../../../utils/hooks/bottomSheet";
 import { IdPayPaymentRoutes } from "../../idpay/payment/navigation/routes";

diff --git a/ts/features/bonus/cgn/screens/CgnDetailScreen.tsx b/ts/features/bonus/cgn/screens/CgnDetailScreen.tsx
@@ -32,7 +32,7 @@ import { useIOSelector } from "../../../../store/hooks";
 import {
   cgnMerchantVersionSelector,
   isCGNEnabledSelector
-} from "../../../../store/reducers/backendStatus";
+} from "../../../../store/reducers/backendStatus/remoteConfig";
 import { profileSelector } from "../../../../store/reducers/profile";
 import { GlobalState } from "../../../../store/reducers/types";
 import { formatDateAsShortFormat } from "../../../../utils/dates";

diff --git a/ts/features/bonus/cgn/screens/activation/CgnCTAStartActivationScreen.tsx b/ts/features/bonus/cgn/screens/activation/CgnCTAStartActivationScreen.tsx
@@ -5,7 +5,7 @@ import { Alert } from "react-native";
 import { connect } from "react-redux";
 import { Dispatch } from "redux";
 import I18n from "../../../../../i18n";
-import { isCGNEnabledSelector } from "../../../../../store/reducers/backendStatus";
+import { isCGNEnabledSelector } from "../../../../../store/reducers/backendStatus/remoteConfig";
 import { GlobalState } from "../../../../../store/reducers/types";
 import { useActionOnFocus } from "../../../../../utils/hooks/useOnFocus";
 import { ID_CGN_TYPE } from "../../../common/utils";

diff --git a/ts/features/bonus/common/screens/AvailableBonusScreen.tsx b/ts/features/bonus/common/screens/AvailableBonusScreen.tsx
@@ -31,7 +31,7 @@ import { Dispatch } from "../../../../store/actions/types";
 import {
   isCGNEnabledSelector,
   isCdcEnabledSelector
-} from "../../../../store/reducers/backendStatus";
+} from "../../../../store/reducers/backendStatus/remoteConfig";
 import { GlobalState } from "../../../../store/reducers/types";
 import { storeUrl } from "../../../../utils/appVersion";
 import { loadServiceDetail } from "../../../services/details/store/actions/details";