chore(Cross): [IOAPPX-357] Upgrade @gorhom/bottom-sheet library
#6062
+77,501
−76,625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
…into IOAPPX-357-upgrade-bs-lib
dmnplb
changed the title
@gorhom/bottom-sheet library
|
The problem we discussed yesterday does not seem to be related to the package version. By the way, I noticed that the visual issue seems to be related to the |
…6317) ## Short description This pull request includes changes to the `getPayerInfoLabel` function and its corresponding tests to improve the formatting of the payer's tax code. The main change is the removal of parentheses around the tax code in the output. ## List of changes proposed in this pull request - Remove parenthesis from `getPayerInfoLabel` function - Update `getPayerInfoLabel` test ## How to test - Go into `Pagamenti` - Tap on a payment from the list - Check the tax code under the payer name ## Preview <img width="499" alt="Screenshot 2024-10-21 at 17 59 33" src="https://github.com/user-attachments/assets/0a356ef3-64d9-4531-8d74-4c7521ef5f69">
…6213) ##⚠️ This PR depends on #6187⚠️ ## Short description This PR adds the refresh control with the pull-to-refresh feature inside the biz-events transaction list screen ## List of changes proposed in this pull request - Added the `refreshing` property and the `onRefresh` handler to the SectionList. - Added the `isRefreshing` state that changes when the user pull down to refresh the content. ## How to test - With the dev-server started, open the `Payments` home page; - Tap on the `Show all` CTA on the top right corner of the list; - You should be able to pull to refresh the content when inside that list; ## Preview https://github.com/user-attachments/assets/9ebbecc3-c507-466b-ad87-ec852d16a85e --------- Co-authored-by: Mario Perrotta <[email protected]>
## Short description This pull request includes a change to the `PaymentsMethodDetailsScreen` component to enhance the `getCardHeaderTitle` function. The update adds specific handling for BPAY and PayPal payment methods. ## List of changes proposed in this pull request - Update `getCardHeaderTitle` function to handle missing edge cases ## How to test ### io-dev-server To test all card cases, update the `generateWalletData` function by adding this line: `generateUserWallet(3)` ### io-app - Tap in _Portafoglio_ - BPAY or PayPal card - Verify the correct card header title is displayed --------- Co-authored-by: Alessandro <[email protected]>
## Short description This pull request removes the banner that prompts users to go to the payments section when they want to pay a notice from the wallet screen. ## List of changes proposed in this pull request - Delete `WalletPaymentsRedirectBanner` component and its redux variable ## How to test - Navigate to the Portafoglio (Wallet) section. - Verify that the banner prompting for payment redirection no longer appears. --------- Co-authored-by: Alessandro <[email protected]>
…6313) ## Short description This pull request includes several changes to the `CgnMerchantCategoriesListScreen.tsx` and `categories.ts` files to improve the handling of the first render state and loading indicators. ## List of changes proposed in this pull request - Update CGN categories store loading state to `noneLoading` - Ensure the `RefreshControl` component does not appear on the first render. ## How to test - Enter into CGN detail screen - Press on _Scopri le opportunità_ - Check the list transition --------- Co-authored-by: Alessandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR aims to upgrade bottom-sheet library to solve rendering glitches
List of changes proposed in this pull request
How to test
Check the bottom-sheet behaviour to be self consistent