Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Cross): [IOAPPX-362,IOAPPX-364] Replace TypographyFactory with IOText + Add support for Bold Text a11y setting #6076

Merged
merged 111 commits into from
Oct 21, 2024
Merged

chore(Cross): [IOAPPX-362,IOAPPX-364] Replace TypographyFactory with IOText + Add support for Bold Text a11y setting #6076

merged 111 commits into from
Oct 21, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jul 31, 2024 •
edited
Loading

Warning

This PR depends on:

Short description

This PR replaces the typographic styles generated through useTypographyFactory with the new generic IOText typographic style. It also adds the support for the Bold text a11y setting to all the existing typographic styles.

List of changes proposed in this pull request

  • Update io-app-design-system to 2.0.0
  • Replace LabelLink with the relative Label… styles with the new asLink prop
  • Update DSTypography page to reflect all the latest changes
    • Remove MdH4, MdH5 and MdH6 typographic styles because not necessary

Preview

bold-text.mov

How to test

To define

@dmnplb dmnplb added a11y Activities related to accessibility Design System New visual language and reduction of previous UI clutter labels Jul 31, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-362] Replace TypographyFactory with IOText + Add support for Bold Text a11y setting chore(Cross): [IOAPPX-362] Replace TypographyFactory with IOText + Add support for Bold Text a11y setting Jul 31, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 31, 2024 •
edited by jira bot
Loading

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • ⚙️ IOAPPX-362: Aggiunta di IOText al posto degli stili tipografici generati con useTypographyFactory
    subtask of
  • ⚙️ IOAPPX-364: [io-app] Aggiunta del supporto dell'impostazione Testo in grassetto
    subtask of

Generated by 🚫 dangerJS against 9a418d8

@dmnplb dmnplb changed the title chore(Cross): [IOAPPX-362] Replace TypographyFactory with IOText + Add support for Bold Text a11y setting chore(Cross): [IOAPPX-362, IOAPPX-364] Replace TypographyFactory with IOText + Add support for Bold Text a11y setting Jul 31, 2024
@dmnplb dmnplb mentioned this pull request Oct 15, 2024
Open
@dmnplb dmnplb added Dark mode 🌝 and removed code review needed 💻📱 Insert this label if you need a code review that no one in your team can give you labels Oct 17, 2024
@dmnplb dmnplb mentioned this pull request Oct 17, 2024
Open
CrisTofani
CrisTofani approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit caf8138 into master Oct 21, 2024
13 checks passed
@dmnplb dmnplb deleted the IOAPPX-362-add-IOText branch October 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

Assignees
No one assigned
Labels
a11y Activities related to accessibility Cross Dark mode 🌝 Design System New visual language and reduction of previous UI clutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmnplb @pagopa-github-bot @CrisTofani