feat: [IOBP-863,IOBP-864] Removed legacy wallet & payments features #6210
+652
−32,257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hantex9
added
IO-Bonus e pagamenti
Affected stories |
Hantex9
requested review from
ChrisMattew,
gispada and
freddi301
as code owners
LeleDallas
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Great work, it works as expected! 🎊
What I suggest here is to remove some unused files in payments folder:
ts/features/payments/checkout/types/PaymentHistory.tsts/features/payments/checkout/types/WalletPaymentPspSortType.tsts/features/payments/common/components/PaymentCardBankLogo.tsxts/features/payments/home/components/PaymentsListItemTransaction.tsx
Use npx knip to double check them
LeleDallas
reviewed
Nov 5, 2024
| // wallets with undefined creation dates... so the check | ||
| // is unnecessary. | ||
|
|
||
| isNaN(a.created as any) || isNaN(b.created as any) |
There was a problem hiding this comment.
Instead of use any here what do you think about this: isNaN(Number(a.created)) || isNaN(Number(b.created)) ? Will this approach be more type-safe?
|
|
||
| // the error is undefined in case we weren't able to decode it, it should be | ||
| // interpreted as a generic error | ||
| export const paymentVerifica = createAsyncAction( |
There was a problem hiding this comment.
Could you confirm if it was intentional to leave this declaration in Italian?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR removes all elements related to the old wallet, payment flow, and onboarding process. It includes the deletion of screens, components, sagas, reducers, and other elements associated with these deprecated features.
N.B: The goal of this PR is solely to remove the legacy payments flow and does not include refactoring the deprecated components displayed on some screens such as IDPay. Please keep this in mind when reviewing the PR.
List of changes proposed in this pull request
How to test
To test this PR, both the new payment flow and the onboarding flow must work correctly. Additionally, it's important to test a payment initiated from the Message screen. @forrest57 @Vangaorth, this PR cannot be merged until it is approved by the communication team.
Please test everything both in local environment and UAT env. (by enabling the feature flag
Ambiente di test pagoPAand building the app with the .env.production variables)