Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1745] IT Wallet copy review #6302

Merged
merged 13 commits into from
Oct 18, 2024

Conversation

ale-mazz
Copy link
Contributor

@ale-mazz ale-mazz commented Oct 17, 2024

This pull request includes various updates to the localization files locales/en/index.yml and locales/it/index.yml to improve the consistency and clarity of the translated text. The most important changes include updates to terminology, content adjustments for better readability, and corrections to capitalization.

List of changes proposed in this pull request

  • Various modifications to the IT Wallet copy

How to test

  • Test a complete ITW flow, starting with the eID obtainment, then adding a credential, checking every banner/bottom sheet, removing the credential, and revoking the eID.

@ale-mazz ale-mazz self-assigned this Oct 17, 2024
@pagopa-github-bot pagopa-github-bot changed the title feat(IT Wallet): [SIW-1745] IT Wallet copy review chore(IT Wallet): [SIW-1745] IT Wallet copy review Oct 17, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 17, 2024

Affected stories

  • ⚙️ SIW-1745: review copy generale + banner tessera sanitaria
    subtask of
    • SIW-1457: Evoluzione flusso ottenimento credenziale

Generated by 🚫 dangerJS against 47c94f8

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.00%. Comparing base (4f204b4) to head (47c94f8).
Report is 623 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6302      +/-   ##
==========================================
- Coverage   48.42%   47.00%   -1.42%     
==========================================
  Files        1488     1803     +315     
  Lines       31617    36558    +4941     
  Branches     7669     8768    +1099     
==========================================
+ Hits        15311    17185    +1874     
- Misses      16238    19308    +3070     
+ Partials       68       65       -3     
Files with missing lines Coverage Δ
ts/config.ts 100.00% <100.00%> (ø)
...allet/discovery/screens/ItwDiscoveryInfoScreen.tsx 83.33% <ø> (ø)
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 40.00% <ø> (ø)

... and 1415 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3fd6d...47c94f8. Read the comment docs.

@ale-mazz ale-mazz marked this pull request as ready for review October 17, 2024 16:44
@ale-mazz ale-mazz requested review from thisisjp and a team as code owners October 17, 2024 16:44
locales/en/index.yml Outdated Show resolved Hide resolved
locales/en/index.yml Outdated Show resolved Hide resolved
locales/it/index.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LazyAfternoons LazyAfternoons merged commit ba54dae into master Oct 18, 2024
13 checks passed
@LazyAfternoons LazyAfternoons deleted the siw-1745-review-copy-itw branch October 18, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants