Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1723] Cards and documents not always stacked #6309

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RiccardoMolinari95
Copy link
Collaborator

Short description

This PR sets in wallet the stacked style to both ITWallet documents and other cards. The last of these two groups remains with not staked style, showing in full.

List of changes proposed in this pull request

  • Set isStacked prop of withWalletCardBaseComponent always true
  • In WalletCardsCategoryContainer, function renderItem I've retained the check for the last card to ensure that it remains not stacked
  • In WalletCardsContainer.tsx I removed all the stacked prop from ItwCardsContainer and OtherCardsContainer

How to test

To test, you can use o io-api-dev-server and add as many payment methods as you want or use the production app and add both payment methods and ITW documents

Screenshot 2024-10-18 at 15 02 14
Screenshot 2024-10-18 at 15 01 43

Screenshot 2024-10-18 at 15 40 14

@pagopa-github-bot pagopa-github-bot changed the title [SIW-1723] Cards and documents not always stacked fix(IT Wallet): [SIW-1723] Cards and documents not always stacked Oct 18, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 18, 2024

Affected stories

  • 🐞 SIW-1723: Incongruenza rappresentazione stacked card

Generated by 🚫 dangerJS against 1a9047e

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.00%. Comparing base (4f204b4) to head (1a9047e).
Report is 626 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6309      +/-   ##
==========================================
- Coverage   48.42%   47.00%   -1.43%     
==========================================
  Files        1488     1803     +315     
  Lines       31617    36551    +4934     
  Branches     7669     8648     +979     
==========================================
+ Hits        15311    17179    +1868     
- Misses      16238    19315    +3077     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
ts/features/design-system/core/DSWallet.tsx 14.28% <ø> (-2.39%) ⬇️
...s/newWallet/components/WalletCardBaseComponent.tsx 100.00% <100.00%> (ø)
...Wallet/components/WalletCardsCategoryContainer.tsx 100.00% <100.00%> (ø)
...ures/newWallet/components/WalletCardsContainer.tsx 97.77% <100.00%> (+8.88%) ⬆️

... and 1417 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18acf6...1a9047e. Read the comment docs.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants