-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-1723] Cards and documents not always stacked #6309
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6309 +/- ##
==========================================
- Coverage 48.42% 47.00% -1.43%
==========================================
Files 1488 1803 +315
Lines 31617 36551 +4934
Branches 7669 8648 +979
==========================================
+ Hits 15311 17179 +1868
- Misses 16238 19315 +3077
+ Partials 68 57 -11
... and 1417 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR sets in wallet the stacked style to both ITWallet documents and other cards. The last of these two groups remains with not staked style, showing in full.
List of changes proposed in this pull request
isStacked
prop ofwithWalletCardBaseComponent
always trueWalletCardsCategoryContainer
, functionrenderItem
I've retained the check for the last card to ensure that it remains not stackedWalletCardsContainer.tsx
I removed all the stacked prop fromItwCardsContainer
andOtherCardsContainer
How to test
To test, you can use o io-api-dev-server and add as many payment methods as you want or use the production app and add both payment methods and ITW documents