Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-407] Remove instabug leftovers from native projects #6311

Merged

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Oct 19, 2024

Short description

This PR removes instabug, which is an old dependency, leftovers from native projects.

List of changes proposed in this pull request

  • Remove instabug from ProGuard rules on Android;
  • Remove instabug framework references from the iOS project.

How to test

# If you store DeriveData with relative path to the project folder, otherwise use Xcode to clean the build
> rm -rf ios/DerivedData 
> rm -rf ios/Pods
> cd ios && bundler exec pod install && cd .. 
> yarn react-native run-ios

> cd android && ./gradlew/clean
> yarn react-native run-android

This should also fix a warning we receive when building the iOS app.

@LazyAfternoons LazyAfternoons requested a review from a team as a code owner October 19, 2024 12:50
@LazyAfternoons LazyAfternoons changed the title [IOAPPX-407]chore: remove instabug from native projects [IOAPPX-407] Remove instabug leftovers from native projects Oct 19, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-407] Remove instabug leftovers from native projects chore(Cross): [IOAPPX-407] Remove instabug leftovers from native projects Oct 19, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 19, 2024

Affected stories

  • ⚙️ IOAPPX-407: [io-app] Rimozione rimanenze dipendenza instabug nei progetti nativi
    subtask of

Generated by 🚫 dangerJS against 347435b

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.00%. Comparing base (4f204b4) to head (347435b).
Report is 664 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6311      +/-   ##
==========================================
- Coverage   48.42%   47.00%   -1.43%     
==========================================
  Files        1488     1815     +327     
  Lines       31617    36902    +5285     
  Branches     7669     8898    +1229     
==========================================
+ Hits        15311    17346    +2035     
- Misses      16238    19490    +3252     
+ Partials       68       66       -2     

see 1440 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c43bc0b...347435b. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds and runs as expected on both Android and iOS

@LazyAfternoons LazyAfternoons merged commit 47fd544 into master Nov 1, 2024
13 checks passed
@LazyAfternoons LazyAfternoons deleted the IOAPPX-407-remove-instabug-from-native-projects branch November 1, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants