-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOBP-838] Remove receipt from list #6334
base: master
Are you sure you want to change the base?
Conversation
…m/pagopa/io-app into IOBP-838-remove-receipt-from-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, It looks good to me! Maybe consider adding a js-doc to the utility function. After that, you're free to merge the PR 👍
index: number | ||
): NoticeListItem => pot.getOrElse(transactions, [])[index]; | ||
|
||
export const restoreTransactionAtIndex = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be useful for a jsdoc to explain the purpose of this utility function better?
This PR depends on
Short description
This pull request introduces a new feature to hide receipts from the list
List of changes proposed in this pull request
PaymentsTransactionBizEventsDetailsScreen
How to test
Dev-server
config.ts
set a delay and edit thehideReceiptResponseCode
propertyNascondi dalla lista
Preview
Screen.Recording.2024-10-29.at.11.37.44.mov
Screen.Recording.2024-10-29.at.11.39.53.mov
Screen.Recording.2024-10-29.at.11.40.58.mov
@thisisjp would it make sense to set a minimum delay before displaying the Loading component? This could help avoid the component flashing on screen for very short loading times, leading to a smoother user experience.