Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PE-630] CGN partner search screen #6336

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

freddi301
Copy link
Collaborator

@freddi301 freddi301 commented Oct 28, 2024

Short description

Added a partner's search new screen.
Refer to screens in https://pagopa.atlassian.net/browse/PE-630 description.

List of changes proposed in this pull request

  • add labels
  • remove search functionality in discount list by operators
  • add new search page

How to test

To test with dev-api-server this PR is needed pagopa/io-dev-api-server#432
I did not made this PR depend on it since it is testable using other backend environments

Going to the new search screen option 1:

  • login into the app
  • go to CGN card trough wallet (add it if necessary)
  • press discover opportunities
  • press magnifying icon in the top bar

Going to the new search screen option 2:

  • login into the app
  • go to CGN card trough wallet (add it if necessary)
  • press discover opportunities
  • go to any category
  • press magnifying icon in the top bar

Testing the search screen

  • Go to the new search screen
  • search for partner
  • check if you see the results
  • press on a result and check if it opens the correct screen

@freddi301 freddi301 added Carta Giovani Nazionale copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. labels Oct 28, 2024
@freddi301 freddi301 requested review from thisisjp and a team as code owners October 28, 2024 10:20
@freddi301 freddi301 marked this pull request as draft October 28, 2024 10:20
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 28, 2024

Affected stories

  • 🌟 PE-630: [FE] Implementazione barra di ricerca "cross"
    subtask of
    • PE-730: [Convenzione] Miglioramento ricerca agevolazioni in app

Generated by 🚫 dangerJS against c149b7a

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 2.63158% with 111 lines in your changes missing coverage. Please review.

Project coverage is 46.95%. Comparing base (4f204b4) to head (c149b7a).
Report is 642 commits behind head on master.

Files with missing lines Patch % Lines
.../cgn/screens/merchants/CgnMerchantSearchScreen.tsx 2.97% 98 Missing ⚠️
ts/hooks/useDebouncedValue.ts 0.00% 8 Missing ⚠️
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 0.00% 3 Missing ⚠️
...n/screens/merchants/CgnMerchantsListByCategory.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6336      +/-   ##
==========================================
- Coverage   48.42%   46.95%   -1.48%     
==========================================
  Files        1488     1810     +322     
  Lines       31617    36856    +5239     
  Branches     7669     8807    +1138     
==========================================
+ Hits        15311    17306    +1995     
- Misses      16238    19494    +3256     
+ Partials       68       56      -12     
Files with missing lines Coverage Δ
ts/features/bonus/cgn/navigation/navigator.tsx 70.00% <ø> (ø)
ts/features/bonus/cgn/navigation/routes.ts 100.00% <ø> (ø)
...s/cgn/screens/merchants/CgnMerchantsListScreen.tsx 9.37% <ø> (-0.89%) ⬇️
...n/screens/merchants/CgnMerchantsListByCategory.tsx 1.69% <0.00%> (-4.98%) ⬇️
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 25.00% <0.00%> (+22.36%) ⬆️
ts/hooks/useDebouncedValue.ts 0.00% <0.00%> (ø)
.../cgn/screens/merchants/CgnMerchantSearchScreen.tsx 2.97% <2.97%> (ø)

... and 1430 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb0f41...c149b7a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Carta Giovani Nazionale copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants