-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IT Wallet): [SIW-1797,SIW-1608] Handle all credential statuses for the physical and digital document #6349
Open
gispada
wants to merge
38
commits into
master
Choose a base branch
from
SIW-1797-credentials-extended-status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+974
−690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SIW-1797-credentials-extended-status
…SIW-1797-credentials-extended-status
…SIW-1797-credentials-extended-status
Affected stories
|
gispada
requested review from
dmnplb,
a team,
thisisjp,
ChrisMattew and
freddi301
as code owners
October 31, 2024 13:38
mastro993
reviewed
Oct 31, 2024
Base automatically changed from
SIW-1780-credential-status-error-during-issuance
to
master
October 31, 2024 16:29
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on #6338
Short description
This PR extends the status set of credentials, that are now defined as follows:
valid
,expiring
,expired
,invalid
(as attested by the status attestation)valid
,jwtExpiring
,jwtExpired
This is necessary because there are several UI differences that depend on those statuses. In case of overlapping between the physical and digital document a specific order has been defined (see
IO-WALLET-DR-0018
): the utility functiongetCredentialStatus
has been modified accordingly and must be considered the only source of truth for the status.Additionally when the status attestation returns a specific error code and this code is successfully mapped with one of the
issuance_errors_supported
, the credential detail screen will show a dynamic alert with a bottom sheet based on this error.List of changes proposed in this pull request
itwTypesUtils
(and removed the unusedpending
status)ItwPresentationAlertsSection
into two components:ItwPresentationCredentialInfoAlert
to display informative content about the credentialItwPresentationCredentialStatusAlert
to display an alert related to the credential status (both dynamic and static content)getCredentialStatus
and added more unit testsvalid
,jwtExpiring
andjwtExpired
(digital credential only)How to test
To test this PR there are two ways:
/status
response with a 404 and a body like{ "error": "credential_voided" }
(check the EC to find the exact error codes)jwt.expiration
)It is also possible to force the return value of
getCredentialStatus
with the desired status.Refer to the approved only Figma, "Ciclo di vita credenziali."