refactor: removed unused Support Token functionality

pagopa · Oct 23, 2024 · 16bd993 · 16bd993
1 parent ad9f8e9
commit 16bd993
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 238 deletions.
diff --git a/.env.example b/.env.example
@@ -34,11 +34,6 @@ FF_IO_SIGN_ENABLED=1
 FF_IO_WALLET_ENABLED=1
 FF_IO_WALLET_TRIAL_ENABLED=1
 
-JWT_SUPPORT_TOKEN_PRIVATE_RSA_KEY="-----BEGIN RSA PRIVATE KEY-----\n
-<APrivateRSAKEY>\n
------END RSA PRIVATE KEY-----"
-JWT_SUPPORT_TOKEN_ISSUER=io-backend
-
 # ------------------------------------
 # FnAppMessages Env Variables
 # ------------------------------------

diff --git a/src/app.ts b/src/app.ts
@@ -97,7 +97,6 @@ import {
 import ServicesAppBackendController from "./controllers/serviceAppBackendController";
 import SessionLockController from "./controllers/sessionLockController";
 import { getUserForMyPortal } from "./controllers/ssoController";
-import SupportController from "./controllers/supportController";
 import UserDataProcessingController from "./controllers/userDataProcessingController";
 import { ISessionStorage } from "./services/ISessionStorage";
 import AuthenticationLockService from "./services/authenticationLockService";
@@ -464,7 +463,6 @@ export async function newApp({
           PAGOPA_PROXY_SERVICE,
           USER_METADATA_STORAGE,
           USER_DATA_PROCESSING_SERVICE,
-          TOKEN_SERVICE,
           authMiddlewares.bearerSession,
           LOLLIPOP_API_CLIENT
         );
@@ -757,7 +755,6 @@ function registerAPIRoutes(
   pagoPaProxyService: PagoPAProxyService,
   userMetadataStorage: RedisUserMetadataStorage,
   userDataProcessingService: UserDataProcessingService,
-  tokenService: TokenService,
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   bearerSessionTokenAuth: any,
   lollipopClient: ReturnType<typeof LollipopApiClient>
@@ -796,10 +793,6 @@ function registerAPIRoutes(
   const userDataProcessingController: UserDataProcessingController =
     new UserDataProcessingController(userDataProcessingService);
 
-  const supportController: SupportController = new SupportController(
-    tokenService
-  );
-
   app.get(
     `${basePath}/profile`,
     bearerSessionTokenAuth,
@@ -996,12 +989,6 @@ function registerAPIRoutes(
       pagoPAProxyController
     )
   );
-
-  app.get(
-    `${basePath}/token/support`,
-    bearerSessionTokenAuth,
-    toExpressHandler(supportController.getSupportToken, supportController)
-  );
 }
 
 // eslint-disable-next-line max-params

diff --git a/src/config.ts b/src/config.ts
@@ -408,44 +408,6 @@ export const FF_EUCOVIDCERT_ENABLED =
 export const FF_MIT_VOUCHER_ENABLED =
   process.env.FF_MIT_VOUCHER_ENABLED === "1";
 
-// Support Token
-export const JWT_SUPPORT_TOKEN_PRIVATE_RSA_KEY = pipe(
-  process.env.JWT_SUPPORT_TOKEN_PRIVATE_RSA_KEY,
-  NonEmptyString.decode,
-  E.getOrElseW((errs) => {
-    log.error(
-      `Missing or invalid JWT_SUPPORT_TOKEN_PRIVATE_RSA_KEY environment variable: ${readableReport(
-        errs
-      )}`
-    );
-    return process.exit(1);
-  })
-);
-export const JWT_SUPPORT_TOKEN_ISSUER = pipe(
-  process.env.JWT_SUPPORT_TOKEN_ISSUER,
-  NonEmptyString.decode,
-  E.getOrElseW((errs) => {
-    log.error(
-      `Missing or invalid JWT_SUPPORT_TOKEN_ISSUER environment variable: ${readableReport(
-        errs
-      )}`
-    );
-    return process.exit(1);
-  })
-);
-
-const DEFAULT_JWT_SUPPORT_TOKEN_EXPIRATION = 604800 as Second;
-export const JWT_SUPPORT_TOKEN_EXPIRATION: Second = pipe(
-  process.env.JWT_SUPPORT_TOKEN_EXPIRATION,
-  IntegerFromString.decode,
-  E.getOrElseW(() => DEFAULT_JWT_SUPPORT_TOKEN_EXPIRATION)
-) as Second;
-
-log.info(
-  "JWT support token expiration set to %s seconds",
-  JWT_SUPPORT_TOKEN_EXPIRATION
-);
-
 // Mit  Voucher Token
 export const JWT_MIT_VOUCHER_TOKEN_PRIVATE_ES_KEY = pipe(
   process.env.JWT_MIT_VOUCHER_TOKEN_PRIVATE_ES_KEY,

diff --git a/src/controllers/__tests__/supportController.test.ts b/src/controllers/__tests__/supportController.test.ts
diff --git a/src/controllers/supportController.ts b/src/controllers/supportController.ts
diff --git a/src/services/__tests__/tokenService.test.ts b/src/services/__tests__/tokenService.test.ts
@@ -13,15 +13,6 @@ const aLastname = "Rossi" as NonEmptyString;
 const aFiscalCode = "AAAAAAAAAAAAAAA" as FiscalCode;
 const anEmailAddress = "[email protected]" as EmailString;
 const aSharedSecret = "ASHAREDSECRET123" as NonEmptyString;
-const aPrivateRsaKey = `-----BEGIN RSA PRIVATE KEY-----
-MIIBOgIBAAJBAPX91rBDbLk5Pr0/lf4y1a8oz75sYa+slTqpfVHUrYb22qy4rY6Z
-B0rXvTeLPgCAXUfGFJu4qSJcbu7yhBrPx30CAwEAAQJBALRCvEVUU2L0IRabdvXd
-GJuP45ReZcNPS9e+BhimKjcgVFmyrpmiItNBHKFyTM8uL8dHXen1ReUgZOHcPKpV
-MF0CIQD8KxN+ZhrxPIMPEJJJOO/Pn4y3iZRowulkaFDFUMUzzwIhAPm6vD95LAJW
-DyC2relGDbA6h/YrBg38fcr1KQgxe0bzAiAcUL30oIR/+BqDU4oJnNIYz0KezV0T
-0mcgtjHzphkuswIgXbRK1IpUECBYls7VHNXTZw/fWmg0YmUeklxBZDik6C8CIBXl
-niQ7qszA7Uel9+wv2DwzWj+8OUcRzJAGOVD8cy2S
------END RSA PRIVATE KEY-----` as NonEmptyString;
 const tokenTtl = 60 as Second;
 const aTokenIssuer = "ISSUER" as NonEmptyString;
 
@@ -56,32 +47,6 @@ describe("TokenService#getNewTokenAsync", () => {
   });
 });
 
-describe("TokenService#getSupportToken", () => {
-  it("should generate a new support token", async () => {
-    // generate new token
-    const tokenService = new TokenService();
-    const errorOrNewJwtToken = await tokenService.getJwtSupportToken(
-      aPrivateRsaKey,
-      aFiscalCode,
-      tokenTtl,
-      aTokenIssuer
-    )();
-    expect(E.isRight(errorOrNewJwtToken)).toBeTruthy();
-  });
-
-  it("should return an error if an error occurs during token generation", async () => {
-    // generate new token
-    const tokenService = new TokenService();
-    const errorOrNewJwtToken = await tokenService.getJwtSupportToken(
-      "aPrivateRsaKey" as NonEmptyString,
-      aFiscalCode,
-      tokenTtl,
-      aTokenIssuer
-    )();
-    expect(E.isLeft(errorOrNewJwtToken)).toBeTruthy();
-  });
-});
-
 describe("TokenService#getJwtMitVoucherToken", () => {
   it("should generate a token for mit voucher", async () => {
     // generate new token

diff --git a/src/services/tokenService.ts b/src/services/tokenService.ts
@@ -37,38 +37,6 @@ export default class TokenService {
     return asyncRandomBytes(length).then((_) => _.toString("hex"));
   }
 
-  /**
-   * Generates a new support token containing the logged user's fiscalCode.
-   *
-   * @param privateKey: The RSA's private key used to sign this JWT token
-   * @param fiscalCode: The logged user's FiscalCode
-   * @param tokenTtl: Token Time To live (expressed in seconds)
-   * @param issuer: The Token issuer
-   */
-  public getJwtSupportToken(
-    privateKey: NonEmptyString,
-    fiscalCode: FiscalCode,
-    tokenTtl: Second,
-    issuer: NonEmptyString
-  ): TaskEither<Error, string> {
-    return pipe(
-      TE.taskify<Error, string>((cb) =>
-        jwt.sign(
-          { fiscalCode },
-          privateKey,
-          {
-            algorithm: "RS256",
-            expiresIn: `${tokenTtl} seconds`,
-            issuer,
-            jwtid: ulid(),
-          },
-          cb
-        )
-      )(),
-      TE.mapLeft(E.toError)
-    );
-  }
-
   /**
    * Generates a new zendesk support token containing the logged user's fiscalCode and email address.
    *