Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [SIW-1849] Added trial system FF #1172

Merged
merged 7 commits into from
Nov 19, 2024
Merged

chore: [SIW-1849] Added trial system FF #1172

merged 7 commits into from
Nov 19, 2024

Conversation

silvicir
Copy link
Contributor

@silvicir silvicir commented Nov 15, 2024 •
edited
Loading

List of Changes

Added FF_IO_WALLET_TRIAL_ENABLED check even in getTrialSubscription endpoint

Motivation and Context

So we can remove trial system everywhere with FF

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1849

@silvicir silvicir marked this pull request as ready for review November 18, 2024 16:34
@silvicir silvicir requested a review from a team as a code owner November 18, 2024 16:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@silvicir silvicir merged commit bb0d1f7 into master Nov 19, 2024
6 checks passed
@silvicir silvicir deleted the SIW-1849-add-FF-to-wallet-ts branch November 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grausof grausof grausof approved these changes

@gquadrati gquadrati Awaiting requested review from gquadrati gquadrati is a code owner automatically assigned from pagopa/io-backend-contributors

@StefanoDoc StefanoDoc Awaiting requested review from StefanoDoc StefanoDoc is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvicir @grausof