Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPLT-932] Upgrade to node version 20.17.0 #1178

Merged
merged 13 commits into from
Feb 3, 2025
Merged

[IOPLT-932] Upgrade to node version 20.17.0 #1178

merged 13 commits into from
Feb 3, 2025

Conversation

robbcocco
Copy link
Collaborator

@robbcocco robbcocco commented Jan 30, 2025 •
edited
Loading

List of Changes

Upgraded Node version required to run the project to Node 20.17.0

Motivation and Context

This change was needed to upgrade the stack

How Has This Been Tested?

Tested by running yarn test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@robbcocco robbcocco requested a review from a team as a code owner January 30, 2025 13:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPLT-932

@robbcocco robbcocco marked this pull request as draft January 30, 2025 16:28
@robbcocco robbcocco changed the title [IOPLT-932] Upgrade to node version 20.18.2 [IOPLT-932] Upgrade to node version 20.17.0 Jan 31, 2025
@robbcocco robbcocco marked this pull request as ready for review February 3, 2025 08:26
BurnedMarshal
BurnedMarshal requested changes Feb 3, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
src/@types/bwip-js/index.d.ts Outdated Show resolved Hide resolved
src/@types/passport-auth-token/index.d.ts Outdated Show resolved Hide resolved
src/@types/passport-http-custom-bearer/index.d.ts Outdated Show resolved Hide resolved
eslint.config.mjs Show resolved Hide resolved
src/controllers/cgnController.ts Outdated Show resolved Hide resolved
src/controllers/fimsController.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

BurnedMarshal
BurnedMarshal approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BurnedMarshal BurnedMarshal merged commit 64c692a into master Feb 3, 2025
6 checks passed
@BurnedMarshal BurnedMarshal deleted the IOPLT-932_upgrade_to_node20 branch February 3, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@pagopa-github-bot pagopa-github-bot Awaiting requested review from pagopa-github-bot pagopa-github-bot is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robbcocco @BurnedMarshal @roberto-cocco-ey