fix: errors and tested

src/_modules/data_factory_storage_account/datasets_containers.tf

@@ -1,6 +1,6 @@
 resource "azurerm_data_factory_custom_dataset" "source_dataset_container" {
-  for_each        = local.containers
-  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value.name}-blob-${module.naming_convention.suffix}"
+  for_each        = toset(local.containers)
+  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value}-blob-${module.naming_convention.suffix}"
   data_factory_id = var.data_factory_id
   type            = "AzureBlob"
 
@@ -14,13 +14,13 @@ resource "azurerm_data_factory_custom_dataset" "source_dataset_container" {
       type          = "LinkedServiceReference"
     }
     type       = "AzureBlob"
-    folderPath = each.value.name
+    folderPath = each.value
   })
 }
 
 resource "azurerm_data_factory_custom_dataset" "target_dataset_container" {
-  for_each        = local.containers
-  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.target.name}-${each.value.name}-blob-${module.naming_convention.suffix}"
+  for_each        = toset(local.containers)
+  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.target.name}-${each.value}-blob-${module.naming_convention.suffix}"
   data_factory_id = var.data_factory_id
   type            = "AzureBlob"
 
@@ -34,6 +34,6 @@ resource "azurerm_data_factory_custom_dataset" "target_dataset_container" {
       type          = "LinkedServiceReference"
     }
     type       = "AzureBlob"
-    folderPath = each.value.name
+    folderPath = each.value
   })
 }

src/_modules/data_factory_storage_account/datasets_tables.tf

@@ -1,6 +1,6 @@
 resource "azurerm_data_factory_custom_dataset" "source_dataset_table" {
-  for_each        = local.tables
-  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value.name}-table-${module.naming_convention.suffix}"
+  for_each        = toset(local.tables)
+  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value}-table-${module.naming_convention.suffix}"
   data_factory_id = var.data_factory_id
   type            = "AzureTable"
 
@@ -9,13 +9,13 @@ resource "azurerm_data_factory_custom_dataset" "source_dataset_table" {
   }
 
   type_properties_json = jsonencode({
-    tableName = each.value.name
+    tableName = each.value
   })
 }
 
 resource "azurerm_data_factory_custom_dataset" "target_dataset_table" {
-  for_each        = local.tables
-  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.target.name}-${each.value.name}-table-${module.naming_convention.suffix}"
+  for_each        = toset(local.tables)
+  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.target.name}-${each.value}-table-${module.naming_convention.suffix}"
   data_factory_id = var.data_factory_id
   type            = "AzureTable"
 
@@ -24,6 +24,6 @@ resource "azurerm_data_factory_custom_dataset" "target_dataset_table" {
   }
 
   type_properties_json = jsonencode({
-    tableName = each.value.name
+    tableName = each.value
   })
 }

src/_modules/data_factory_storage_account/locals.tf

@@ -1,4 +1,6 @@
 locals {
   containers = var.what_to_migrate.blob.enabled ? (length(var.what_to_migrate.blob.containers) > 0 ? var.what_to_migrate.blob.containers : [for container in data.azurerm_storage_containers.this[0].containers : container.name]) : []
-  tables     = var.what_to_migrate.table.enabled ? (length(var.what_to_migrate.table.tables) > 0 ? var.what_to_migrate.table.tables : [for table in jsondecode(data.azapi_resource_list.tables.output).value : table.TableName]) : []
+
+  azapi_tables = jsondecode(data.azapi_resource_list.tables.output)
+  tables     = var.what_to_migrate.table.enabled ? (length(var.what_to_migrate.table.tables) > 0 ? var.what_to_migrate.table.tables : [for table in local.azapi_tables.value : table.name]) : []
 }

src/_modules/data_factory_storage_account/outputs.tf

@@ -1,6 +1,6 @@
 output "pipelines" {
   value = {
-    for pipeline in concat(azurerm_data_factory_pipeline.pipeline_container, azurerm_data_factory_pipeline.pipeline_table)
+    for pipeline in merge(azurerm_data_factory_pipeline.pipeline_container, azurerm_data_factory_pipeline.pipeline_table)
     : pipeline.name => {
       id   = pipeline.id
       name = pipeline.name

src/_modules/data_factory_storage_account/pipeline_containers.tf

@@ -1,6 +1,6 @@
 resource "azurerm_data_factory_pipeline" "pipeline_container" {
-  for_each        = local.containers
-  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value.name}-blob-${module.naming_convention.suffix}"
+  for_each        = toset(local.containers)
+  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value}-blob-${module.naming_convention.suffix}"
   data_factory_id = var.data_factory_id
 
   activities_json = jsonencode(

src/_modules/data_factory_storage_account/pipeline_tables.tf

@@ -1,6 +1,6 @@
 resource "azurerm_data_factory_pipeline" "pipeline_table" {
-  for_each        = local.tables
-  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value.name}-table-${module.naming_convention.suffix}"
+  for_each        = toset(local.tables)
+  name            = "${module.naming_convention.prefix}-adf-${var.storage_accounts.source.name}-${each.value}-table-${module.naming_convention.suffix}"
   data_factory_id = var.data_factory_id
 
   activities_json = jsonencode(

src/migration/prod/locals.tf

@@ -25,11 +25,18 @@ locals {
   }
 
   storage_accounts = [
-    {
-      source = { name = "iopweuabc", resource_group_name = "abc" }
-      target = { name = "iopitnabc", resource_group_name = "abc" }
-      blob   = { enabled = true }
-      table  = { enabled = true }
-    }
+    # Copy both containers and tables
+    # {
+    #   source = { name = "stdevbiptest1", resource_group_name = "RG-BIP-DEV-TEST" }
+    #   target = { name = "stbipdevtest1", resource_group_name = "dev-fasanorg" }
+    # },
+    #
+    # Copy only selected containers and tables
+    # {
+      #   source = { name = "stdevbiptest1", resource_group_name = "RG-BIP-DEV-TEST" }
+      #   target = { name = "stbipdevtest1", resource_group_name = "dev-fasanorg" }
+    #   blob = {enabled = true, containers = ["c1", "c2", "c3"]}
+    #   table = {enabled = true, tables = ["t1", "t2", "t3"]}
+    # }
   ]
 }

src/migration/prod/main.tf

@@ -10,7 +10,7 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = "<= 3.112.0"
+      version = "<= 3.116.0"
     }
 
     azapi = {