-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CES-157] - Implement tooling for storage account migration from WEU to ITN #1238
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd do the following:
- link a Jira issue into the title (ie. [CES-100]
- use a more descriptive title
- follow pull request template describing the PR
Feel free to keep PRs in draft until review is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that everything that is committed must be in english.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory structure is incorrect because the data_factory
module should be placed within the _modules
folder, at the same level as test_users
. Additionally, the environment/dev
path should be placed within the relevant domain where the resource is intended to be created.
Also, the dev
folder content needs review, as the final configuration for production should already be defined in this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please use the pull requets template and provide motivation and context. PR title should reflect purpose, not changes. |
PR title and description updated accordingly. Does it look ok? |
Quality Gate passedIssues Measures |
Motivation and Context
The decided strategy for the migration of storage accounts to Italy North entails the usage of Data Factory.
This PR introduces a module and scaffolding to create the necessary resources.
Major Changes
Create a module and scaffolding for the creation of data factory resources for the copy of blob and table data in storage accounts.
Dependencies
Testing
The resources have been tested deeply in the DEV-ENGINEERING subscription.
The following is an example of configuration derived from the migration of a test storage account:
Example of data factory configuration used for tests:
Documentation
Other Considerations