CES-218-migrate-ioplollipopassertionsst new module code #1266
Conversation
cfcuffari120400
had a problem deploying
to
prod-ci
GitHub Actions
Failure
|
| module "azure_storage_account" { | ||
| source = "github.com/pagopa/dx//infra/modules/azure_storage_account?ref=main" | ||
|
|
||
| environment = var.environment |
There was a problem hiding this comment.
| environment = var.environment | |
| environment = local.itn_environment |
| subnet_pep_id = var.subnet_pendpoints_id | ||
| private_dns_zone_resource_group_name = var.resource_group_common |
There was a problem hiding this comment.
These values can be gotten from the common_values module
| subnet_pep_id = var.subnet_pendpoints_id | |
| private_dns_zone_resource_group_name = var.resource_group_common | |
| subnet_pep_id = module.common_values.pep_subnets.weu.id | |
| private_dns_zone_resource_group_name = module.common_values.resource_groups.weu.common |
| queue = true | ||
| } | ||
|
|
||
| action_group_id = data.azurerm_monitor_action_group.example.id |
There was a problem hiding this comment.
Is this actually necessary? Does the existing storage account have alerts?
| itn_environment = { | ||
| prefix = var.prefix | ||
| env_short = var.env_short | ||
| location = var.location_short |
There was a problem hiding this comment.
location contains the full name of the azure region. In this case, with this itn_environment local, we want to address resources created in italynorth. We can use the existing itn_location local
| location = var.location_short | |
| location = local.itn_location |
|
|
||
| variable "subnet_pendpoints_id" { | ||
| type = string | ||
| description = "Id of the subnet which holds private endpoints" | ||
| } | ||
|
|
||
| variable "resource_group_common" { | ||
| type = string | ||
| description = "Name of the common resource group" | ||
| } |
There was a problem hiding this comment.
These variables can be removed since we are getting this information from the common_values module
| variable "subnet_pendpoints_id" { | |
| type = string | |
| description = "Id of the subnet which holds private endpoints" | |
| } | |
| variable "resource_group_common" { | |
| type = string | |
| description = "Name of the common resource group" | |
| } |
| location = "westeurope" | ||
| secondary_location = "italynorth" |
There was a problem hiding this comment.
We already have a local containing the italynorth location. It's called itn_location on row 30
| location = "westeurope" | |
| secondary_location = "italynorth" |
Motivation and Context
Major Changes
Dependencies
Testing
Documentation
Other Considerations