[CES-111] Add private endpoints to Cosmos api without altering DNS #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krusty93
force-pushed
the
CES-111-cosmos-db-replica-read-only-italy-north-common
branch
from
214f2fa
to
3554da7
Compare
|
📖 Terraform Plan ('src/common/prod') - successTerraform Plandata.azurerm_linux_function_app.wallet_user: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.fims_op_app: Still reading... [10s elapsed]
data.azurerm_linux_web_app.firmaconio_selfcare_web_app: Still reading... [10s elapsed]
data.azurerm_linux_function_app.app_messages_xl[0]: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_continua: Still reading... [10s elapsed]
data.azurerm_linux_function_app.eucovidcert: Still reading... [10s elapsed]
data.azurerm_linux_function_app.app_messages_xl[1]: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_assets_cdn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.session_manager_04: Still reading... [10s elapsed]
data.azurerm_linux_function_app.wallet_user: Still reading... [20s elapsed]
data.azurerm_linux_function_app.function_profile[1]: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_profile[0]: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [10s elapsed]
data.azurerm_linux_function_app.io_sign_user: Still reading... [10s elapsed]
data.azurerm_linux_function_app.services_app_backend_function_app: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.session_manager_03: Still reading... [10s elapsed]
data.azurerm_linux_function_app.lollipop_function: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_cgn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_selfcare_be: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [20s elapsed]
data.azurerm_linux_function_app.lollipop_function: Still reading... [20s elapsed]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
Terraform will perform the following actions:
# module.application_gateway_weu.azurerm_web_application_firewall_policy.api_app will be updated in-place
~ resource "azurerm_web_application_firewall_policy" "api_app" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-external/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/io-p-waf-appgateway-api-app-policy"
name = "io-p-waf-appgateway-api-app-policy"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra"
}
# (4 unchanged attributes hidden)
~ policy_settings {
~ request_body_inspect_limit_in_kb = 0 -> 128
# (6 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# module.cosmos_api_weu.azurerm_private_endpoint.sql_itn will be created
+ resource "azurerm_private_endpoint" "sql_itn" {
+ custom_dns_configs = (known after apply)
+ id = (known after apply)
+ location = "italynorth"
+ name = "io-p-itn-api-cosno-pep-01"
+ network_interface = (known after apply)
+ private_dns_zone_configs = (known after apply)
+ resource_group_name = "io-p-rg-internal"
+ subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-pep-snet-01"
+ tags = {
+ "CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
+ "CreatedBy" = "Terraform"
+ "Environment" = "Prod"
+ "Owner" = "IO"
+ "Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
+ private_service_connection {
+ is_manual_connection = false
+ name = "io-p-itn-api-cosno-pep-01"
+ private_connection_resource_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.DocumentDB/databaseAccounts/io-p-cosmos-api"
+ private_ip_address = (known after apply)
+ subresource_names = [
+ "Sql",
]
}
}
# module.app_backend_li_weu.module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
~ app_settings = {
~ "CGN_API_URL" = "https://io-p-cgn-fn.azurewebsites.net" -> "https://io-p-itn-cgn-card-func-01.azurewebsites.net"
# (108 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendli"
name = "io-p-app-appbackendli"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (24 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.app_backend_li_weu.module.appservice_app_backend_slot_staging.azurerm_linux_web_app_slot.this will be updated in-place
~ resource "azurerm_linux_web_app_slot" "this" {
~ app_settings = {
~ "CGN_API_URL" = "https://io-p-cgn-fn.azurewebsites.net" -> "https://io-p-itn-cgn-card-func-01.azurewebsites.net"
# (108 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendli/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (24 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.app_backend_weu["1"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
~ app_settings = {
~ "CGN_API_URL" = "https://io-p-cgn-fn.azurewebsites.net" -> "https://io-p-itn-cgn-card-func-01.azurewebsites.net"
# (108 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl1"
name = "io-p-app-appbackendl1"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (24 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.app_backend_weu["2"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
~ app_settings = {
~ "CGN_API_URL" = "https://io-p-cgn-fn.azurewebsites.net" -> "https://io-p-itn-cgn-card-func-01.azurewebsites.net"
# (108 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl2"
name = "io-p-app-appbackendl2"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (24 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.app_backend_weu["3"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
~ app_settings = {
~ "CGN_API_URL" = "https://io-p-cgn-fn.azurewebsites.net" -> "https://io-p-itn-cgn-card-func-01.azurewebsites.net"
# (108 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl3"
name = "io-p-app-appbackendl3"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (24 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.application_gateway_weu.module.app_gw.azurerm_application_gateway.this will be updated in-place
~ resource "azurerm_application_gateway" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-external/providers/Microsoft.Network/applicationGateways/io-p-appgateway"
name = "io-p-appgateway"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra"
}
# (8 unchanged attributes hidden)
~ autoscale_configuration {
~ min_capacity = 10 -> 20
# (1 unchanged attribute hidden)
}
# (86 unchanged blocks hidden)
}
Plan: 1 to add, 7 to change, 0 to destroy.
Warning: Argument is deprecated
with module.application_gateway_weu.azurerm_web_application_firewall_policy.api_app,
on ../_modules/application_gateway/firewall.tf line 62, in resource "azurerm_web_application_firewall_policy" "api_app":
62: disabled_rules = [
63: "942100",
64: "942120",
65: "942190",
66: "942200",
67: "942210",
68: "942240",
69: "942250",
70: "942260",
71: "942330",
72: "942340",
73: "942370",
74: "942380",
75: "942430",
76: "942440",
77: "942450",
78: ]
`disabled_rules` will be removed in favour of the `rule` property in version
4.0 of the AzureRM Provider.
(and 50 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
christian-calabrese
approved these changes
Nov 5, 2024
mamu0
approved these changes
Nov 5, 2024
Krusty93
deleted the
CES-111-cosmos-db-replica-read-only-italy-north-common
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The new private endpoints are located in ItalyNorth region and will be used when we will run the region failover between ItalyNorth and WestEurope. These new PEPs allow applications running in ItalyNorth to not routing packets towards WestEurope, gaining in performances
Major Changes
Add private endpoints to the cosmos-api instance
Dependencies
Testing
Documentation
Other Considerations