Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set taxCode in sc-contracts as optional field #287

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

silvicir
Copy link
Contributor

List of Changes

The taxCode property in the contractSchema and institutionDetailSchema have become optional

Motivation and Context

In the message arriving on the sc-contracts queue, the taxCode property in institution has become optional

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 6b903d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
io-sign-backoffice-func Patch
io-sign-backoffice-app Patch
@io-sign/io-sign Patch
io-func-sign-issuer Patch
io-func-sign-support Patch
io-func-sign-user Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gunzip
Copy link
Contributor

gunzip commented May 15, 2024

wouldn't this return null for existing records?

@silvicir
Copy link
Contributor Author

wouldn't this return null for existing records?

what do you mean?

@gunzip
Copy link
Contributor

gunzip commented May 16, 2024

wouldn't this return null for existing records?

what do you mean?

existing records have taxCode as id, so when you'll call issuerAlreadyExists({ id: internalIstitutionID }) won't it return false? Do you plan to revisit all insitutions to migrate?

@silvicir
Copy link
Contributor Author

wouldn't this return null for existing records?

what do you mean?

existing records have taxCode as id, so when you'll call issuerAlreadyExists({ id: internalIstitutionID }) won't it return false? Do you plan to revisit all insitutions to migrate?

Yes i will add new documents in the collection before deploying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants